Derby
  1. Derby
  2. DERBY-5033

[patch] System.arraycopy, being native, is more performant

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 10.7.1.1
    • Fix Version/s: 10.8.1.2
    • Component/s: Network Client
    • Labels:
      None
    • Urgency:
      Low
    • Bug behavior facts:
      Performance

      Description

      various places in the code, manual loops are used to copy one array to another, switch with System.arraycopy for better performance.

      1. use_arraycopy.diff
        4 kB
        Dave Brosius
      2. use_arraycopy_2.diff
        4 kB
        Knut Anders Hatlen

        Activity

        Hide
        Knut Anders Hatlen added a comment -

        Regression tests passed. Committed revision 1070677.

        Show
        Knut Anders Hatlen added a comment - Regression tests passed. Committed revision 1070677.
        Hide
        Knut Anders Hatlen added a comment -

        Thanks, Dave. This looks like a good simplification of the code. One of the arraycopy() calls in DecryptionManager was added without removing the corresponding loop. Attaching an updated patch (use_arraycopy_2.diff) that also removes the loop.

        Running regression tests now.

        Show
        Knut Anders Hatlen added a comment - Thanks, Dave. This looks like a good simplification of the code. One of the arraycopy() calls in DecryptionManager was added without removing the corresponding loop. Attaching an updated patch (use_arraycopy_2.diff) that also removes the loop. Running regression tests now.

          People

          • Assignee:
            Dave Brosius
            Reporter:
            Dave Brosius
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1h
              1h
              Remaining:
              Remaining Estimate - 1h
              1h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development