Derby
  1. Derby
  2. DERBY-5015

Use Arrays.fill() in client/am/ResultSet.java

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 10.8.1.2
    • Fix Version/s: 10.8.1.2
    • Component/s: Network Client
    • Labels:
      None
    • Issue & fix info:
      Patch Available

      Description

      client/am/ResultSet.java uses Arrays.fill() to clear arrays in some cases, but I noticed a couple of places where it still uses for loops to clear the arrays. The code would become a tiny bit simpler if Arrays.fill() was used these other places too.

      1. fill.diff
        1 kB
        Knut Anders Hatlen

        Activity

        Knut Anders Hatlen created issue -
        Knut Anders Hatlen made changes -
        Field Original Value New Value
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        Knut Anders Hatlen added a comment -

        The attached patch replaces three for loops with calls to Arrays.fill(). All the regression tests ran cleanly.

        Show
        Knut Anders Hatlen added a comment - The attached patch replaces three for loops with calls to Arrays.fill(). All the regression tests ran cleanly.
        Knut Anders Hatlen made changes -
        Attachment fill.diff [ 12470661 ]
        Hide
        Knut Anders Hatlen added a comment -

        Revision: 1069354
        Author: kahatlen
        Date: 2011-02-10 13:19
        Message: #DERBY-5015: Use Arrays.fill() in client/am/ResultSet.java

        Show
        Knut Anders Hatlen added a comment - Revision: 1069354 Author: kahatlen Date: 2011-02-10 13:19 Message: # DERBY-5015 : Use Arrays.fill() in client/am/ResultSet.java
        Knut Anders Hatlen made changes -
        Original Estimate 0h [ 0 ]
        Remaining Estimate 0h [ 0 ]
        Knut Anders Hatlen made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Issue & fix info [Patch Available] [Patch Available, Patch Available]
        Resolution Fixed [ 1 ]
        Knut Anders Hatlen made changes -
        Fix Version/s 10.8.0.0 [ 12315561 ]
        Component/s Network Client [ 11690 ]
        Knut Anders Hatlen made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Rick Hillegas made changes -
        Affects Version/s 10.8.1.1 [ 12316356 ]
        Affects Version/s 10.8.1.0 [ 12315561 ]
        Fix Version/s 10.8.1.1 [ 12316356 ]
        Fix Version/s 10.8.1.0 [ 12315561 ]
        Rick Hillegas made changes -
        Affects Version/s 10.8.1.2 [ 12316362 ]
        Affects Version/s 10.8.1.1 [ 12316356 ]
        Fix Version/s 10.8.1.2 [ 12316362 ]
        Fix Version/s 10.8.1.1 [ 12316356 ]
        Gavin made changes -
        Workflow jira [ 12544994 ] Default workflow, editable Closed status [ 12801022 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        4s 1 Knut Anders Hatlen 09/Feb/11 08:02
        In Progress In Progress Resolved Resolved
        1d 4h 16m 1 Knut Anders Hatlen 10/Feb/11 12:19
        Resolved Resolved Closed Closed
        1m 50s 1 Knut Anders Hatlen 10/Feb/11 12:21

          People

          • Assignee:
            Knut Anders Hatlen
            Reporter:
            Knut Anders Hatlen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development