Uploaded image for project: 'Derby'
  1. Derby
  2. DERBY-4968

Let query stop execution if an interrupt is seen, at same time as we check the query timeout

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 10.8.1.2
    • Component/s: Store
    • Labels:
      None
    • Issue & fix info:
      Patch Available

      Description

      Subtask of DERBY-4741.
      In BasicNoPutResultSetImpl#checkCancellationFlag we currently check whether a statement has been canceled or it timed out at certain times during query execution. We would like an interrupt seen during execution hitherto to also throw at this point. Cf the way we also stop execution of batches if a batch element sees an interrupt.

      1. derby-4968-1.diff
        1 kB
        Dag H. Wanvik
      2. derby-4968-1.stat
        0.1 kB
        Dag H. Wanvik

        Issue Links

          Activity

          Hide
          dagw Dag H. Wanvik added a comment - - edited

          Attaching a patch which lets checkCancellationFlag throw SQLState.CONN_INTERRUPT (the thread's interrupt flag is also set).

          The exception was generated at the time the interrupt was seen so the stack trace would show exactly when this was picked up. Possibly we should wrap it in another to show that we are throwing in checkCancellationFlag.

          Show
          dagw Dag H. Wanvik added a comment - - edited Attaching a patch which lets checkCancellationFlag throw SQLState.CONN_INTERRUPT (the thread's interrupt flag is also set). The exception was generated at the time the interrupt was seen so the stack trace would show exactly when this was picked up. Possibly we should wrap it in another to show that we are throwing in checkCancellationFlag.
          Hide
          dagw Dag H. Wanvik added a comment -

          suitesAll passed ok.

          Show
          dagw Dag H. Wanvik added a comment - suitesAll passed ok.
          Hide
          dagw Dag H. Wanvik added a comment -

          Committed as svn 1058251, resolving. Post-commit reviews are welcome!

          Show
          dagw Dag H. Wanvik added a comment - Committed as svn 1058251, resolving. Post-commit reviews are welcome!
          Hide
          knutanders Knut Anders Hatlen added a comment -

          [bulk update] Close all resolved issues that haven't been updated for more than one year.

          Show
          knutanders Knut Anders Hatlen added a comment - [bulk update] Close all resolved issues that haven't been updated for more than one year.

            People

            • Assignee:
              dagw Dag H. Wanvik
              Reporter:
              dagw Dag H. Wanvik
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development