Derby
  1. Derby
  2. DERBY-4933

Use framework helper methods to check result sets in DatabaseMetaDataTest

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 10.8.1.2
    • Fix Version/s: 10.8.1.2
    • Component/s: Test
    • Labels:
      None

      Description

      Some of the test cases in DatabaseMetaDataTest manually iterate through result sets and verify their contents against a canon. They should use JDBC.assertFullResultSet() instead.

      1. d4933.diff
        20 kB
        Knut Anders Hatlen

        Activity

        Hide
        Knut Anders Hatlen added a comment -

        Attaching a patch that replaces the code that loops through the result sets with calls to JDBC.assertFullResultSet().

        DatabaseMetaDataTest runs cleanly with the patch, but I'll also run the full test suite to verify that it doesn't break anything, since the test may run in other contexts than standalone (at least as part of the upgrade tests and collation tests, and perhaps others).

        Show
        Knut Anders Hatlen added a comment - Attaching a patch that replaces the code that loops through the result sets with calls to JDBC.assertFullResultSet(). DatabaseMetaDataTest runs cleanly with the patch, but I'll also run the full test suite to verify that it doesn't break anything, since the test may run in other contexts than standalone (at least as part of the upgrade tests and collation tests, and perhaps others).
        Hide
        Knut Anders Hatlen added a comment -

        Committed revision 1043039.

        Show
        Knut Anders Hatlen added a comment - Committed revision 1043039.

          People

          • Assignee:
            Knut Anders Hatlen
            Reporter:
            Knut Anders Hatlen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development