Uploaded image for project: 'Derby'
  1. Derby
  2. DERBY-4918

Minor refactoring of SPSDescriptor

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 10.8.1.2
    • 10.8.1.2
    • SQL
    • None

    Description

      The class SPSDescriptor is kind of hard to understand, and doesn't quite follow the pattern used by other tuple descriptors. Parts of the code don't agree with the documentation (i.e. SPS_TYPE_TRIGGER marked as not implemented)
      This issue tracks work to make the class easier to understand and to modify.
      The critical part that may need to be changed is the use of synchronized (this). The problem is that database locks are obtained within the critical regions, and in some special cases this causes deadlocks. I'm not yet certain this can be fixed at this level (only), but I'll continue investigation.

      Attachments

        1. derby-4918-1a-misc.diff
          10 kB
          Kristian Waagan
        2. derby-4918-1a-misc.stat
          0.3 kB
          Kristian Waagan
        3. derby-4918-2a-remove_setUUID.diff
          2 kB
          Kristian Waagan
        4. derby-4918-2b-remove_setUUID.diff
          2 kB
          Kristian Waagan

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            kristwaa Kristian Waagan
            kristwaa Kristian Waagan
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment