Derby
  1. Derby
  2. DERBY-4867

Update BaseTestCase.isSunJVM() to accept Oracle

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 10.7.1.1
    • Fix Version/s: 10.7.1.1
    • Component/s: Test
    • Labels:
      None

      Description

      The latest builds of JDK 7 at https://jdk7.dev.java.net/ have "Oracle Corporation" in the system property java.vendor. Since isSunJVM() only checks for "Sun Microsystems Inc.", some tests will be excluded on JDK 7 even if they would have worked. We should update isSunJVM() to return true for "Oracle Corporation" too.

      1. oracle.diff
        0.7 kB
        Knut Anders Hatlen

        Activity

        Hide
        Knut Anders Hatlen added a comment -

        The attached patch makes isSunJVM() return true if java.vendor is one of "Sun Microsystems Inc." and "Oracle Corporation".

        Without the patch, Derby151Test (e.g.) will be skipped with JDK 7. I've verified that the test is not skipped when the patch is applied.

        Show
        Knut Anders Hatlen added a comment - The attached patch makes isSunJVM() return true if java.vendor is one of "Sun Microsystems Inc." and "Oracle Corporation". Without the patch, Derby151Test (e.g.) will be skipped with JDK 7. I've verified that the test is not skipped when the patch is applied.
        Hide
        Knut Anders Hatlen added a comment -

        Committed revision 1028643.

        Show
        Knut Anders Hatlen added a comment - Committed revision 1028643.

          People

          • Assignee:
            Knut Anders Hatlen
            Reporter:
            Knut Anders Hatlen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development