Derby
  1. Derby
  2. DERBY-4866

Simplify SYSCS_BULK_INSERT with IdUtil.mkQualifiedName()

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 10.7.1.1
    • Fix Version/s: 10.7.1.1
    • Component/s: Tools
    • Labels:
      None

      Description

      SystemProcedures.SYSCS_BULK_INSERT contains this piece of code:

      String entityName = IdUtil.normalToDelimited(tableName);
      if (schemaName != null)

      { entityName = IdUtil.normalToDelimited(schemaName) + "." + entityName; }

      The helper method IdUtil.mkQualifiedName() could do the exact same in one line.

      1. d4866.diff
        0.8 kB
        Knut Anders Hatlen

        Activity

        Hide
        Knut Anders Hatlen added a comment -

        Committed revision 1028648.

        Show
        Knut Anders Hatlen added a comment - Committed revision 1028648.
        Hide
        Knut Anders Hatlen added a comment -

        The attached patch makes SYSCS_BULK_INSERT use the helper method. All regression tests ran cleanly with the patch.

        Show
        Knut Anders Hatlen added a comment - The attached patch makes SYSCS_BULK_INSERT use the helper method. All regression tests ran cleanly with the patch.

          People

          • Assignee:
            Knut Anders Hatlen
            Reporter:
            Knut Anders Hatlen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development