[DERBY-4792] Synchronized setter method but non-synchronized similarly-name getter method in ClientBaseDataSource

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 10.5.1.1
• Component/s: JDBC
• Labels: derby_triage10_5_2
• Environment: OS: Windows XP
• Urgency: Normal
• Assignee: Unassigned
• Reporter: Wendy Feng
• Created: 06/Sep/10 02:30
• Updated: 15/Feb/11 21:08

Description

I found some synchronized setter methods and unsynchronized similarly-named getter methods in class ClientBaseDataSource as follow:

public abstract class ClientBaseDataSource implements Serializable, Referenceable {
...
synchronized public void setTraceLevel(int traceLevel)

{ this.traceLevel = traceLevel; }

public int getTraceLevel()

{ return this.traceLevel; }

..
}

Consequence:
traceLevel is not declared volatile, the Java Memory Model doesn't guarantee up-to-date field value visible to threads in the absent of synchronization. So if the getTraceLevel() method is called, it could read stale or inconsistent values, which could cause serious problems.

Quick-fix solution:
synchronize getTraceLevel() method