Derby
  1. Derby
  2. DERBY-4764

Files with missing ASF license headers

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 10.7.1.1
    • Fix Version/s: 10.7.1.1
    • Component/s: Miscellaneous
    • Labels:
      None

      Description

      There are some files (consisting of creative works) without license headers in the repository. Some files are also using a different text for the Apache License header then the other files.
      I plan to add the license header after having verified that the files were uploaded to Jira with the grant license to ASF bullet ticked.

      The list of files I have identified so far, grouped based on the assumed action required.

      — Add license header
      java/testing/org/apache/derbyTesting/functionTests/tests/memory/TriggerTests.java
      java/engine/org/apache/derby/impl/sql/catalog/XPLAINStatementDescriptor.java
      java/engine/org/apache/derby/impl/sql/catalog/XPLAINScanPropsDescriptor.java
      java/engine/org/apache/derby/impl/sql/catalog/XPLAINResultSetDescriptor.java
      java/engine/org/apache/derby/impl/sql/catalog/XPLAINStatementTimingsDescriptor.java
      java/engine/org/apache/derby/impl/sql/catalog/XPLAINSortPropsDescriptor.java
      java/engine/org/apache/derby/impl/sql/catalog/XPLAINResultSetTimingsDescriptor.java
      java/engine/org/apache/derby/impl/sql/catalog/XPLAINTableDescriptor.java
      java/engine/org/apache/derby/impl/sql/execute/xplain/XPLAINSystemTableVisitor.java
      java/engine/org/apache/derby/impl/sql/execute/xplain/XPLAINDefaultVisitor.java
      java/engine/org/apache/derby/impl/sql/execute/xplain/XPLAINFactory.java
      java/engine/org/apache/derby/impl/sql/execute/xplain/XPLAINUtil.java
      java/engine/org/apache/derby/iapi/sql/execute/xplain/XPLAINFactoryIF.java
      java/engine/org/apache/derby/iapi/sql/execute/xplain/XPLAINable.java
      java/engine/org/apache/derby/iapi/sql/execute/xplain/XPLAINVisitor.java
      java/tools/org/apache/derby/tools/PlanExporter.java
      java/tools/org/apache/derby/impl/tools/planexporter/TreeNode.java
      java/tools/org/apache/derby/impl/tools/planexporter/AccessDatabase.java
      java/tools/org/apache/derby/impl/tools/planexporter/CreateHTMLFile.java
      java/tools/org/apache/derby/impl/tools/planexporter/CreateXMLFile.java

      — Update license header
      java/engine/org/apache/derby/impl/services/jmxnone/NoManagementService.java
      java/engine/org/apache/derby/impl/services/jmx/JMXManagementService.java
      java/engine/org/apache/derby/iapi/services/jmx/ManagementService.java

      — Consider adding header
      java/shared/org/apache/derby/shared/common/sanity/SanityState.java
      java/shared/org/apache/derby/shared/common/sanity/SanityState.tmpl

      java/tools/org/apache/derby/impl/tools/planexporter/resources/advancedViewXSL.xsl
      java/tools/org/apache/derby/impl/tools/planexporter/resources/vanilla_html.xsl
      java/tools/org/apache/derby/impl/tools/planexporter/resources/advancedViewXSL2.xsl

      The SanityState classes seem to come from somewhere. Does anyone have the history? Can we add the ASF license header?
      The xsl files also look like creative works to me. Any objections on that?

        Activity

        Hide
        Rick Hillegas added a comment -

        Hi Kristian,

        SanityState.java is a generated file created from SanityState.tmpl by the "state" target in the master build file. That target just substitutes "true" or "false" for the @SANE@ literal. I think you will get what you want if you just add the Apache header to SanityState.tmpl. Thanks.

        Show
        Rick Hillegas added a comment - Hi Kristian, SanityState.java is a generated file created from SanityState.tmpl by the "state" target in the master build file. That target just substitutes "true" or "false" for the @SANE@ literal. I think you will get what you want if you just add the Apache header to SanityState.tmpl. Thanks.
        Hide
        Kristian Waagan added a comment -

        Attached patch 'derby-4764-1a-license_headers_trunk.diff', and committed it to trunk with revision 984922.
        I wasn't quite sure what to do about the "Class - " line in the XSL files, for now I only specified the base name (without extension). Feel free to change them if you feel like.

        Show
        Kristian Waagan added a comment - Attached patch 'derby-4764-1a-license_headers_trunk.diff', and committed it to trunk with revision 984922. I wasn't quite sure what to do about the "Class - " line in the XSL files, for now I only specified the base name (without extension). Feel free to change them if you feel like.
        Hide
        Kristian Waagan added a comment -

        I'm not sure whether to backport these changes. What to people think?

        The changes made on trunk cannot be merged cleanly because some files don't exist on older branches, but I have a script that will insert the missing headers. One may also be able to manually tweak the merge.

        Show
        Kristian Waagan added a comment - I'm not sure whether to backport these changes. What to people think? The changes made on trunk cannot be merged cleanly because some files don't exist on older branches, but I have a script that will insert the missing headers. One may also be able to manually tweak the merge.
        Hide
        Kristian Waagan added a comment -

        As noted under DERBY-4587, my changes to the XSL files broke the PlanExporter tool. The problem has been corrected under that issue (won't affect a backport, those files only exist in trunk at the moment).

        Show
        Kristian Waagan added a comment - As noted under DERBY-4587 , my changes to the XSL files broke the PlanExporter tool. The problem has been corrected under that issue (won't affect a backport, those files only exist in trunk at the moment).
        Hide
        Kristian Waagan added a comment -

        Closing issue.

        Show
        Kristian Waagan added a comment - Closing issue.

          People

          • Assignee:
            Kristian Waagan
            Reporter:
            Kristian Waagan
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development