[DERBY-4732] Release system resources in CanonTestCase thoroughly

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 10.7.1.1
• Component/s: Test
• Assignee: Yun Lee
• Reporter: Yun Lee
• Created: 06/Jul/10 13:30
• Updated: 29/Nov/10 14:22
• Resolved: 13/Jul/10 14:03

Description

Now, in the method of compareCanon(String canon) in CanonTestcase, two BufferedReaders----cannonReader and testOutput are closed in try catch block, however if some exception occurs above, the two BufferReaders won't be closed, and related system resources won't be released.

Besides, a releative problem is about the ByteArrayOutputStream rawBytes in CanonTestcase, it's created in getOutputStream() and closed in compareCanon(String canon). It's pointed out by Knut in Derby-2708, ByteArrayOutputStream's javadoc says that closing it has no effect, so tearDown() method has been added to CanonTestCase and sets rawBytes to null. It certainly can work. However, is it also OK to null out rawBytes in compareCanon(String canon)? If so, it seems cleaner than to null it out in tearDown() method.

Issue Links

• is part of: DERBY-4609 Derby Test and Fix GSOC 2010 project
• is related to: DERBY-2708 CanonTestCase keeps output from test in memory after it has finished