[DERBY-4687] Avoid unnecessary round-trip for rollback in the client driver

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 10.6.1.0
• Component/s: Network Client
• Labels: Connection client derby_triage10_8 rollback
• Urgency: Low
• Issue & fix info: Newcomer
• Bug behavior facts: Performance
• Assignee: Lily Wei
• Reporter: Lily Wei
• Created: 02/Jun/10 15:07
• Updated: 17/Feb/11 19:11

Description

Per fixing DERBY-4653, the same issue is happening for Connection.rollback().

The methods Connection.rollback() in the client driver cause a round-trip to the server even if the rollback is unnecessary (i.e. there is nothing to roll back).
Comments suggest (see below) that this can be optimized, such that the commands are flowed to the server only when required. It can be seen that this optimization has been used other places in the client driver. Never the less, it must be checked that this optimization doesn't have side-effects and does not create regression.
// Even if we're not in a transaction, all open result sets will be closed.
// So we could probably just return if we're not in a transaction
// using the following code:
// if (!this.inUnitOfWork)
// return;

The protocol tests should be added too.

Issue Links

• relates to: DERBY-4653 Avoid unnecessary round-trip for commit in the client driver