[DERBY-4678] Avoid code duplication in GenericConglomerateController.fetch()

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Won't Fix
• Affects Version/s: 10.7.1.1
• Component/s: Store
• Assignee: Knut Anders Hatlen
• Reporter: Knut Anders Hatlen
• Created: 26/May/10 11:34
• Updated: 29/Nov/10 14:22
• Resolved: 31/May/10 11:39

Description

GenericConglomerateController has two methods named fetch(). One of these methods has a parameter called waitForLock, whereas the other one doesn't have such a parameter. When I diffed the two methods, the only difference I found, apart from a couple of whitespace diffs, was that the method with the waitForLock parameter called lockPosititionForRead/lockPositionForWrite using the parameter value, and the other method called them with a hard-coded value of true.

To avoid duplication of code, fetch(RowLocation,DataValueDescriptor[],FormatableBitSet) should forward calls to fetch(RowLocation,DataValueDescriptor[],FormatableBitSet,boolean).

Issue Links

• relates to: DERBY-4676 NullPointerException on SELECT on INNER JOIN