Derby
  1. Derby
  2. DERBY-4670

ThreadDump class included in insane jars

    Details

      Description

      The ThreadDump class in org.apache.derby.shared.common.sanity is included in the insane versions of derby.jar and derbyclient.jar. The sanity classes should only be included in debug builds.

      1. skip-sanity.diff
        1 kB
        Knut Anders Hatlen

        Activity

        Knut Anders Hatlen created issue -
        Hide
        Myrna van Lunteren added a comment -

        I think we should consider closing this one as won't fix, because I don't think the class can cause any harm in the insane build, as there's nothing calling it.
        The calls are from org.apache.derby.shared.common.sanity.AssertFailure via reflection. AssertFailure is only included in the sane builds.

        ThreadDump only gets into the builds because it's listed in tools/jar/extraDBMSclasses.properties and tools/jar/dnc.properties, and there's no way to separate those into sane and insane.

        Opinions?

        Show
        Myrna van Lunteren added a comment - I think we should consider closing this one as won't fix, because I don't think the class can cause any harm in the insane build, as there's nothing calling it. The calls are from org.apache.derby.shared.common.sanity.AssertFailure via reflection. AssertFailure is only included in the sane builds. ThreadDump only gets into the builds because it's listed in tools/jar/extraDBMSclasses.properties and tools/jar/dnc.properties, and there's no way to separate those into sane and insane. Opinions?
        Hide
        Knut Anders Hatlen added a comment -

        Alternatively, we could make classlister skip all classes in the sanity packages when building insane jars. See attached patch.

        Show
        Knut Anders Hatlen added a comment - Alternatively, we could make classlister skip all classes in the sanity packages when building insane jars. See attached patch.
        Knut Anders Hatlen made changes -
        Field Original Value New Value
        Attachment skip-sanity.diff [ 12480530 ]
        Hide
        Myrna van Lunteren added a comment -

        That works very nicely. +1 to commit...

        Show
        Myrna van Lunteren added a comment - That works very nicely. +1 to commit...
        Hide
        Knut Anders Hatlen added a comment -

        Committed revision 1128243.

        Show
        Knut Anders Hatlen added a comment - Committed revision 1128243.
        Knut Anders Hatlen made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Knut Anders Hatlen [ knutanders ]
        Fix Version/s 10.9.0.0 [ 12316344 ]
        Resolution Fixed [ 1 ]
        Knut Anders Hatlen made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Kathey Marsden added a comment -

        Reopen to adjust affects version, so this shows up on backport list

        Show
        Kathey Marsden added a comment - Reopen to adjust affects version, so this shows up on backport list
        Kathey Marsden made changes -
        Resolution Fixed [ 1 ]
        Status Closed [ 6 ] Reopened [ 4 ]
        Kathey Marsden made changes -
        Affects Version/s 10.7.1.1 [ 12315564 ]
        Affects Version/s 10.8.1.2 [ 12316362 ]
        Hide
        Kathey Marsden added a comment -

        Temporarily assign to myself for backport.

        Show
        Kathey Marsden added a comment - Temporarily assign to myself for backport.
        Kathey Marsden made changes -
        Assignee Knut Anders Hatlen [ knutanders ] Kathey Marsden [ kmarsden ]
        Hide
        Kristian Waagan added a comment -

        Hi Kathey,

        Do you still plan to backport this one?

        Show
        Kristian Waagan added a comment - Hi Kathey, Do you still plan to backport this one?
        Hide
        Kathey Marsden added a comment -

        Yes I will. thank you for the reminder. It slipped off my radar.

        Show
        Kathey Marsden added a comment - Yes I will. thank you for the reminder. It slipped off my radar.
        Hide
        Kathey Marsden added a comment -

        ported fix to 10.8, 10.7 and 10.6 where it first appeared.

        Show
        Kathey Marsden added a comment - ported fix to 10.8, 10.7 and 10.6 where it first appeared.
        Kathey Marsden made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Assignee Kathey Marsden [ kmarsden ] Knut Anders Hatlen [ knutanders ]
        Fix Version/s 10.6.2.3 [ 12315434 ]
        Fix Version/s 10.7.1.4 [ 12315902 ]
        Fix Version/s 10.8.1.6 [ 12316676 ]
        Resolution Fixed [ 1 ]
        Myrna van Lunteren made changes -
        Fix Version/s 10.8.2.0 [ 12317955 ]
        Fix Version/s 10.8.1.6 [ 12316676 ]
        Myrna van Lunteren made changes -
        Fix Version/s 10.8.2.2 [ 12317968 ]
        Fix Version/s 10.8.2.0 [ 12317955 ]
        Knut Anders Hatlen made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Gavin made changes -
        Workflow jira [ 12511387 ] Default workflow, editable Closed status [ 12801055 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        371d 22h 16m 1 Knut Anders Hatlen 27/May/11 11:28
        Closed Closed Reopened Reopened
        1d 6h 17m 1 Kathey Marsden 01/Jul/11 16:38
        Reopened Reopened Resolved Resolved
        46d 6h 23m 1 Kathey Marsden 16/Aug/11 23:02
        Resolved Resolved Closed Closed
        376d 18h 17m 2 Knut Anders Hatlen 24/Jul/12 18:26

          People

          • Assignee:
            Knut Anders Hatlen
            Reporter:
            Knut Anders Hatlen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development