Derby
  1. Derby
  2. DERBY-4670

ThreadDump class included in insane jars

    Details

      Description

      The ThreadDump class in org.apache.derby.shared.common.sanity is included in the insane versions of derby.jar and derbyclient.jar. The sanity classes should only be included in debug builds.

      1. skip-sanity.diff
        1 kB
        Knut Anders Hatlen

        Activity

        Hide
        Myrna van Lunteren added a comment -

        I think we should consider closing this one as won't fix, because I don't think the class can cause any harm in the insane build, as there's nothing calling it.
        The calls are from org.apache.derby.shared.common.sanity.AssertFailure via reflection. AssertFailure is only included in the sane builds.

        ThreadDump only gets into the builds because it's listed in tools/jar/extraDBMSclasses.properties and tools/jar/dnc.properties, and there's no way to separate those into sane and insane.

        Opinions?

        Show
        Myrna van Lunteren added a comment - I think we should consider closing this one as won't fix, because I don't think the class can cause any harm in the insane build, as there's nothing calling it. The calls are from org.apache.derby.shared.common.sanity.AssertFailure via reflection. AssertFailure is only included in the sane builds. ThreadDump only gets into the builds because it's listed in tools/jar/extraDBMSclasses.properties and tools/jar/dnc.properties, and there's no way to separate those into sane and insane. Opinions?
        Hide
        Knut Anders Hatlen added a comment -

        Alternatively, we could make classlister skip all classes in the sanity packages when building insane jars. See attached patch.

        Show
        Knut Anders Hatlen added a comment - Alternatively, we could make classlister skip all classes in the sanity packages when building insane jars. See attached patch.
        Hide
        Myrna van Lunteren added a comment -

        That works very nicely. +1 to commit...

        Show
        Myrna van Lunteren added a comment - That works very nicely. +1 to commit...
        Hide
        Knut Anders Hatlen added a comment -

        Committed revision 1128243.

        Show
        Knut Anders Hatlen added a comment - Committed revision 1128243.
        Hide
        Kathey Marsden added a comment -

        Reopen to adjust affects version, so this shows up on backport list

        Show
        Kathey Marsden added a comment - Reopen to adjust affects version, so this shows up on backport list
        Hide
        Kathey Marsden added a comment -

        Temporarily assign to myself for backport.

        Show
        Kathey Marsden added a comment - Temporarily assign to myself for backport.
        Hide
        Kristian Waagan added a comment -

        Hi Kathey,

        Do you still plan to backport this one?

        Show
        Kristian Waagan added a comment - Hi Kathey, Do you still plan to backport this one?
        Hide
        Kathey Marsden added a comment -

        Yes I will. thank you for the reminder. It slipped off my radar.

        Show
        Kathey Marsden added a comment - Yes I will. thank you for the reminder. It slipped off my radar.
        Hide
        Kathey Marsden added a comment -

        ported fix to 10.8, 10.7 and 10.6 where it first appeared.

        Show
        Kathey Marsden added a comment - ported fix to 10.8, 10.7 and 10.6 where it first appeared.

          People

          • Assignee:
            Knut Anders Hatlen
            Reporter:
            Knut Anders Hatlen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development