Uploaded image for project: 'Derby'
  1. Derby
  2. DERBY-4665

Unidiomatic error handling in TimestampArithTest

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 10.7.1.1
    • Fix Version/s: 10.7.1.1
    • Component/s: Test
    • Labels:
      None

      Description

      TimestampArithTest contains some error handling code that prevents the underlying error from being reported to the JUnit framework, and it may even terminate the JVM running the tests on some errors. Examples:

      This code prints the stack trace of the underlying error to the terminal, but it won't be included in the report from the JUnit framework:

      printStackTrace(sqle);
      fail("Unexpected exception from statement '" + sql + "'");

      This code terminates the JVM on error, preventing subsequent tests from running, and also preventing the JUnit framework to report the results from the tests that did run:

      } catch (Exception e)

      { System.out.println(s + " is not a proper timestamp string."); System.out.println(e.getClass().getName() + ": " + e.getMessage()); e.printStackTrace(); System.exit(1); return null; }

        Attachments

        1. errors.diff
          3 kB
          Knut Anders Hatlen
        2. errors2.diff
          5 kB
          Knut Anders Hatlen

          Activity

            People

            • Assignee:
              knutanders Knut Anders Hatlen
              Reporter:
              knutanders Knut Anders Hatlen
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: