Uploaded image for project: 'Derby'
  1. Derby
  2. DERBY-4651

Hidden assumptions in FromVTI.makeRestriction()

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 10.6.1.0
    • 10.6.2.1, 10.7.1.1
    • SQL
    • None

    Description

      FromVTI.makeRestriction() has this code to strip away Boolean constants from AND and OR expressions:

      // strip off trailing vacuous constant if present
      if ( andOperator.getRightOperand() instanceof BooleanConstantNode )

      { return makeRestriction( andOperator.getLeftOperand(), columnNameMap ); }

      and

      // strip off trailing vacuous constant if present
      if ( orOperator.getRightOperand() instanceof BooleanConstantNode )

      { return makeRestriction( orOperator.getLeftOperand(), columnNameMap ); }

      The code for AND will only work as expected if the right operand is TRUE. The code for OR only works correctly if the right operand is FALSE.

      I'm not sure if this can ever result in user-visible bugs, since Boolean constants are usually removed before we get to this point in the code. The predicate has probably been transformed to conjunctive normal form, in which Boolean constants in the right operand of an AndNode or an OrNode in fact is always TRUE or FALSE, respectively.

      I think this code either should be changed to work regardless of the value of the constant in the right operand, or the assumption that the predicate is on conjunctive normal form should be documented in the comments (and perhaps also checked in an assert statement).

      Attachments

        1. derby-4651-01-aa-verificationTest.diff
          9 kB
          Richard N. Hillegas
        2. derby-4651-02-aa-fixBug.diff
          2 kB
          Richard N. Hillegas
        3. no_cast.diff
          2 kB
          Knut Anders Hatlen

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            rhillegas Richard N. Hillegas
            knutanders Knut Anders Hatlen
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment