Attaching derby-4589-01-ab-missingServiceProperties.diff. This patch adds an error message for the case when the database directory exists but it is missing service.properties. I am running regression tests now.
I agree with Mike's analysis on
DERBY-4733. We should not delete a directory just because it is missing the files which signify an intact database. The best we can do is raise an error suggesting that the problem might be that Derby crashed during database creation. It should remain the user's responsibility to throw away the half-created database and try again.
Touches the following files:
Raise a special error if the database directory exists but it is missing service.properties.
Special error message suggesting that Derby may have crashed during database creation.
Test for this error condition.