Derby
  1. Derby
  2. DERBY-4567

Update the Tools documentation to describe the qualified identifiers which Sylvain just added to ij

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 10.6.1.0
    • Fix Version/s: 10.6.1.0
    • Component/s: Documentation
    • Labels:
      None

      Description

      See DERBY-4550. The ij tool now supports qualified identifiers. Previously only one-part names were allowed for the identifiers bound to prepared statements and cursors. Now those identifiers can have two parts:

      identifier @ connectionName

      1. DERBY-4567.diff
        10 kB
        Kim Haase
      2. DERBY-4567.sql
        0.8 kB
        Sylvain Leroux
      3. DERBY-4567.stat
        0.1 kB
        Kim Haase
      4. DERBY-4567.zip
        9 kB
        Kim Haase
      5. DERBY-4567-2.diff
        17 kB
        Kim Haase
      6. DERBY-4567-2.stat
        0.2 kB
        Kim Haase
      7. DERBY-4567-2.zip
        18 kB
        Kim Haase
      8. DERBY-4567-3.diff
        20 kB
        Kim Haase
      9. DERBY-4567-3.zip
        18 kB
        Kim Haase
      10. DERBY-4567-4.diff
        21 kB
        Kim Haase
      11. DERBY-4567-4.zip
        18 kB
        Kim Haase

        Issue Links

          Activity

          Hide
          Kim Haase added a comment -

          The syntax in the description shows spaces surrounding the @ sign, but none of the examples in DERBY-4550 seem to have spaces. Are spaces allowed, or not?

          Show
          Kim Haase added a comment - The syntax in the description shows spaces surrounding the @ sign, but none of the examples in DERBY-4550 seem to have spaces. Are spaces allowed, or not?
          Hide
          Rick Hillegas added a comment -

          Hi Kim: Spaces are allowed. Regards-Rick

          Show
          Rick Hillegas added a comment - Hi Kim: Spaces are allowed. Regards-Rick
          Hide
          Kim Haase added a comment -

          Thanks for the help, Rick.

          Attaching DERBY-4567.diff, DERBY-4567.stat, and DERBY-4567.zip, with changes to the topics on ij identifier syntax, the prepare command, and the execute command. For prepare I added some information to the text as well as adding an example. For execute the example seemed enough, but I'm open to suggestions.

          I also took advantage of the opportunity to remove from the execute topic a bunch of xrefs to itself and to add to it some syntax xrefs. I also fixed a dumb index entry and a formatting space issue.

          Show
          Kim Haase added a comment - Thanks for the help, Rick. Attaching DERBY-4567 .diff, DERBY-4567 .stat, and DERBY-4567 .zip, with changes to the topics on ij identifier syntax, the prepare command, and the execute command. For prepare I added some information to the text as well as adding an example. For execute the example seemed enough, but I'm open to suggestions. I also took advantage of the opportunity to remove from the execute topic a bunch of xrefs to itself and to add to it some syntax xrefs. I also fixed a dumb index entry and a formatting space issue.
          Hide
          Sylvain Leroux added a comment -

          Hi Kim,

          Thanks for documenting DERBY-4550!

          The new doc appears good to me except that it doesn't explicitly cite examples of qualified identifiers for cursors and async statements.
          Those are somehow of lower interest here than for prepared statements - but nevertheless allowed. I join a file demonstrating that point.

          Please note that for now DERBY-4576 prevents the use of qualified identifiers in GET CURSOR as demonstrated in my example. But a patch is available and that should be fixed in the trunk soon.

          • Sylvain
          Show
          Sylvain Leroux added a comment - Hi Kim, Thanks for documenting DERBY-4550 ! The new doc appears good to me except that it doesn't explicitly cite examples of qualified identifiers for cursors and async statements. Those are somehow of lower interest here than for prepared statements - but nevertheless allowed. I join a file demonstrating that point. Please note that for now DERBY-4576 prevents the use of qualified identifiers in GET CURSOR as demonstrated in my example. But a patch is available and that should be fixed in the trunk soon. Sylvain
          Hide
          Kim Haase added a comment -

          Thank you very much, Sylvain – I will add that information and post a revised patch. I will not try out the GET CURSOR example right away!

          Show
          Kim Haase added a comment - Thank you very much, Sylvain – I will add that information and post a revised patch. I will not try out the GET CURSOR example right away!
          Hide
          Kim Haase added a comment -

          Attaching DERBY-4567-2.diff, DERBY-4567-2.stat, and DERBY-4567-2.zip, with changes to the async, get cursor, and get scroll insensitive cursor command topics in addition to the prepare and execute command topics and the identifier syntax topic.

          I was able to test the cursor commands, thanks to Rick's commit.

          Please let me know what additional changes are needed.

          Show
          Kim Haase added a comment - Attaching DERBY-4567 -2.diff, DERBY-4567 -2.stat, and DERBY-4567 -2.zip, with changes to the async, get cursor, and get scroll insensitive cursor command topics in addition to the prepare and execute command topics and the identifier syntax topic. I was able to test the cursor commands, thanks to Rick's commit. Please let me know what additional changes are needed.
          Hide
          Sylvain Leroux added a comment -

          Hi Kim,

          This is great to me now. Except one minor thing:
          In out/tools/rtoolsijcomref37862.html, the text says "; it must not be the same as any other identifier for an async statement on the current connection".
          But, if a connection name is explicitly given using the @ notation, the identifier must not already be in use for an async statement in the /designated/ connection - however it is allowed to exists in the /current/ connection (if the current connection is not the same as the designated connection of course).

          Thanks again for working on this!

          • Sylvain
          Show
          Sylvain Leroux added a comment - Hi Kim, This is great to me now. Except one minor thing: In out/tools/rtoolsijcomref37862.html, the text says "; it must not be the same as any other identifier for an async statement on the current connection". But, if a connection name is explicitly given using the @ notation, the identifier must not already be in use for an async statement in the /designated/ connection - however it is allowed to exists in the /current/ connection (if the current connection is not the same as the designated connection of course). Thanks again for working on this! Sylvain
          Hide
          Kim Haase added a comment -

          Thanks, Sylvain! I hope I have stated the situation correctly in this latest patch.

          I also added   entities to this topic and another (get cursor) where there were space problems in the PDF and html-single output.

          Show
          Kim Haase added a comment - Thanks, Sylvain! I hope I have stated the situation correctly in this latest patch. I also added   entities to this topic and another (get cursor) where there were space problems in the PDF and html-single output.
          Hide
          Kim Haase added a comment -

          I plan to commit this patch on Monday 3/12 unless I hear there are more issues. Hope that's okay.

          Show
          Kim Haase added a comment - I plan to commit this patch on Monday 3/12 unless I hear there are more issues. Hope that's okay.
          Hide
          Sylvain Leroux added a comment -

          Hi Kim,

          Sorry for the late answer.

          Just a minor thing concerning rtoolsijcomref62772.html I didn't catch last time. The first paragraph of the "description" ends with two nested parenthesis:
          (It does this by issuing a createStatement(ResultSet.TYPE_SCROLL_INSENSITIVE,
          ResultSet.CONCUR_READ_ONLY) call and then executing the statement with
          java.sql.StatementExecuteQuery request on the value of the String.)

          I feel a little bit stupid, but I had to re-read that sentence two or three times before understanding how those parenthesis where balanced. To my discharge, the second opening parenthesis being italicized, I simply don't see it at first!

          So, couldn't we simple drop the most external pair or parenthesis? Just for those like me who aren't completely awake while reading the doc...

          Beside that, I think you've done a great job here!

          Thanks,

          • Sylvain
          Show
          Sylvain Leroux added a comment - Hi Kim, Sorry for the late answer. Just a minor thing concerning rtoolsijcomref62772.html I didn't catch last time. The first paragraph of the "description" ends with two nested parenthesis: (It does this by issuing a createStatement(ResultSet.TYPE_SCROLL_INSENSITIVE, ResultSet.CONCUR_READ_ONLY) call and then executing the statement with java.sql.StatementExecuteQuery request on the value of the String.) I feel a little bit stupid, but I had to re-read that sentence two or three times before understanding how those parenthesis where balanced. To my discharge, the second opening parenthesis being italicized, I simply don't see it at first! So, couldn't we simple drop the most external pair or parenthesis? Just for those like me who aren't completely awake while reading the doc... Beside that, I think you've done a great job here! Thanks, Sylvain
          Hide
          Kim Haase added a comment -

          Thanks, Sylvain. Good catch on that sentence – it's been that way for a long time and it's good to fix it. I also inserted a missing article – I changed "with java.sql.StatementExecuteQuery request" to "with a java.sql.StatementExecuteQuery request".

          I'm attaching DERBY-4567-4.diff and DERBY-4567-4.zip and will go ahead and commit this final patch.

          Show
          Kim Haase added a comment - Thanks, Sylvain. Good catch on that sentence – it's been that way for a long time and it's good to fix it. I also inserted a missing article – I changed "with java.sql.StatementExecuteQuery request" to "with a java.sql.StatementExecuteQuery request". I'm attaching DERBY-4567 -4.diff and DERBY-4567 -4.zip and will go ahead and commit this final patch.
          Hide
          Kim Haase added a comment -

          Committed patch DERBY-4567-4.diff to documentation trunk at revision 923227.

          Show
          Kim Haase added a comment - Committed patch DERBY-4567 -4.diff to documentation trunk at revision 923227.

            People

            • Assignee:
              Kim Haase
              Reporter:
              Rick Hillegas
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development