Derby
  1. Derby
  2. DERBY-4543

CLOB values incorrectly stored on disk using the old header format

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 10.6.1.0
    • Fix Version/s: 10.5.3.1, 10.6.1.0
    • Component/s: JDBC, Store
    • Labels:
      None

      Description

      The logic determining whether CLOB values should be stored using the old (pre 10.5) or the new header format has two bugs, which sometimes causes the old format to be used even though the new one should be used.
      The naming of the relevant methods are also problematic, as we're not really interested in whether we are in soft-upgrade mode or not. If you soft-upgrade from 10.5 to 10.6, the new header format should still be used.

      The consequences of these bugs are potential loss of performance for certain operations on CLOB values and in some cases it might cause a crash if the source stream cannot be rewinded/reset.

        Activity

        Hide
        Kristian Waagan added a comment -

        Patch 1a does three things:

        • added missing !-operator in EmbedPreparedStatement
        • replaced DD_VERSION_CURRENT with DD_VERSION_DERBY_10_5
        • renamed several methods and variables (stop using soft-upgrade mode term, use stream header format instead)

        Regression tests ran without failures.
        Patch ready for review.

        Show
        Kristian Waagan added a comment - Patch 1a does three things: added missing !-operator in EmbedPreparedStatement replaced DD_VERSION_CURRENT with DD_VERSION_DERBY_10_5 renamed several methods and variables (stop using soft-upgrade mode term, use stream header format instead) Regression tests ran without failures. Patch ready for review.
        Hide
        Kristian Waagan added a comment -

        Committed patch 1a to trunk with revision 908418.
        I don't expect more work on this issue, unless something pops up during review.

        Show
        Kristian Waagan added a comment - Committed patch 1a to trunk with revision 908418. I don't expect more work on this issue, unless something pops up during review.
        Hide
        Kristian Waagan added a comment -

        Closing issue.

        Show
        Kristian Waagan added a comment - Closing issue.
        Hide
        Kristian Waagan added a comment -

        Backported to the 10.5 branch with revision 951363.

        Show
        Kristian Waagan added a comment - Backported to the 10.5 branch with revision 951363.

          People

          • Assignee:
            Kristian Waagan
            Reporter:
            Kristian Waagan
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development