Derby
  1. Derby
  2. DERBY-4529

BlobMemTest and ClobMemTest don't call super.tearDown()

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 10.6.1.0
    • Fix Version/s: 10.6.1.0
    • Component/s: Test
    • Labels:
      None

      Description

      The tests memory.BlobMemTest and memory.ClobMemTest have a tearDown() method that looks like this:

      public void tearDown() throws SQLException

      { rollback(); }

      They should also call super.tearDown() in order to perform some additional clean-up (like closing of connection and statements). Since the tearDown() method in BaseJDBCTestCase will also take care of calling rollback() on the connection, there's not actually any need for a specialized tearDown() method in these tests, so I suggest we just remove the methods and let the classes inherit the method from BaseJDBCTestCase.

      1. tearDown.diff
        1 kB
        Knut Anders Hatlen

        Activity

        Hide
        Knut Anders Hatlen added a comment -

        The attached patch removes the two tearDown() methods.

        Show
        Knut Anders Hatlen added a comment - The attached patch removes the two tearDown() methods.
        Hide
        Knut Anders Hatlen added a comment -

        Committed revision 904483.

        Show
        Knut Anders Hatlen added a comment - Committed revision 904483.

          People

          • Assignee:
            Knut Anders Hatlen
            Reporter:
            Knut Anders Hatlen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development