Derby
  1. Derby
  2. DERBY-4522

Document SELECT statement requirements resulting from fix to DERBY-4191

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 10.4.2.0, 10.5.3.0
    • Fix Version/s: 10.6.1.0
    • Component/s: Documentation
    • Labels:
      None

      Description

      The SELECT statement topic needs language based on this release note:

      "Make sure that user has at least one column level select privilege or table level select privilege for queries that do not select a specific column from the tables involved in the SELECT statement. Additionally, subqueries will require that the user has necessary select privileges in order to execute it."

      1. rrefsqlj41360.html
        10 kB
        Kim Haase
      2. DERBY-4522.diff
        1 kB
        Kim Haase
      3. DERBY-4522-2.diff
        4 kB
        Kim Haase
      4. DERBY-4522.stat
        0.1 kB
        Kim Haase
      5. DERBY-4522.zip
        12 kB
        Kim Haase

        Issue Links

          Activity

          Hide
          Kim Haase added a comment -

          Attaching DERBY-4522.diff and rrefsqlj41360.html, which add a short paragraph about required privileges based on the release note for DERBY-4191.

          Should DERBY-4191 be marked as resolved, by the way? It looks as if the fix has been committed.

          Show
          Kim Haase added a comment - Attaching DERBY-4522 .diff and rrefsqlj41360.html, which add a short paragraph about required privileges based on the release note for DERBY-4191 . Should DERBY-4191 be marked as resolved, by the way? It looks as if the fix has been committed.
          Hide
          Kim Haase added a comment -

          I think either Mamta or Rick or Dag could review this patch, if one of you would be so kind. If I don't hear from anyone by Tuesday 2/2 I'll assume it's okay and commit it. Thanks!

          Show
          Kim Haase added a comment - I think either Mamta or Rick or Dag could review this patch, if one of you would be so kind. If I don't hear from anyone by Tuesday 2/2 I'll assume it's okay and commit it. Thanks!
          Hide
          Mamta A. Satoor added a comment -

          The change looks good to me but I might be looking at from an implementor's point of view. It will be nice if Rick/Dag/anyone else can also review it. thanks for working on this, Kim.

          Show
          Mamta A. Satoor added a comment - The change looks good to me but I might be looking at from an implementor's point of view. It will be nice if Rick/Dag/anyone else can also review it. thanks for working on this, Kim.
          Hide
          Dag H. Wanvik added a comment -

          Great to get this documented! Two comments:

          • I think this information should also be present in the GRANT statement topic, in the paragraph that describes SELECT privilege (the one that starts with "Use the SELECT privilege type to grant permission...").
          • Another thing is that in this section in the GRANT topic, the privilege requirements for SELECT is described as necessary for the SELECT statement. Surely, they are also necessary for the SELECT expression (as hinted at to by the sentence mentioning subqueries in the patch's addition to rrefsqlj41360). I think it should be possible to find the required privilege information also when looking at the SELECT expression topic, which is the syntax form used in an INSERT statement. If the required privilege information is also explained in the SELECT expression topic, the extra mention of subqueries would be redundant in the patch. Also, the wording should start:

          "For queries that do not select a specific column from the tables involved in the SELECT statement or expression, ...."

          Show
          Dag H. Wanvik added a comment - Great to get this documented! Two comments: I think this information should also be present in the GRANT statement topic, in the paragraph that describes SELECT privilege (the one that starts with "Use the SELECT privilege type to grant permission..."). Another thing is that in this section in the GRANT topic, the privilege requirements for SELECT is described as necessary for the SELECT statement . Surely, they are also necessary for the SELECT expression (as hinted at to by the sentence mentioning subqueries in the patch's addition to rrefsqlj41360). I think it should be possible to find the required privilege information also when looking at the SELECT expression topic, which is the syntax form used in an INSERT statement. If the required privilege information is also explained in the SELECT expression topic, the extra mention of subqueries would be redundant in the patch. Also, the wording should start: "For queries that do not select a specific column from the tables involved in the SELECT statement or expression, ...."
          Hide
          Kim Haase added a comment -

          Thanks for the suggestions, Dag. I hope this new patch addresses them. I added the information to the GRANT statement and SelectExpression topics, tailoring it to each, and removed the sentence about subqueries. (I also added a link to the SELECT statement topic to the GRANT information (as well as one to the SelectExpression topic).

          Attaching DERBY-4522-2.diff, DERBY-4522.stat, and DERBY-4522.zip.

          Show
          Kim Haase added a comment - Thanks for the suggestions, Dag. I hope this new patch addresses them. I added the information to the GRANT statement and SelectExpression topics, tailoring it to each, and removed the sentence about subqueries. (I also added a link to the SELECT statement topic to the GRANT information (as well as one to the SelectExpression topic). Attaching DERBY-4522 -2.diff, DERBY-4522 .stat, and DERBY-4522 .zip.
          Hide
          Dag H. Wanvik added a comment -

          Thanks, Kim. The changes looks good to me . +1

          Show
          Dag H. Wanvik added a comment - Thanks, Kim. The changes looks good to me . +1
          Hide
          Kim Haase added a comment -

          Thanks, Dag!

          Committed patch DERBY-4522-2.diff to documentation trunk at revision 906505.

          Show
          Kim Haase added a comment - Thanks, Dag! Committed patch DERBY-4522 -2.diff to documentation trunk at revision 906505.
          Hide
          Kim Haase added a comment -

          Forgot to mark this Patch Available ...

          Show
          Kim Haase added a comment - Forgot to mark this Patch Available ...
          Hide
          Kim Haase added a comment -

          Sorry, I'm an idiot. Forgot I was just waiting for the fix to show up in the alpha manuals before closing...

          Show
          Kim Haase added a comment - Sorry, I'm an idiot. Forgot I was just waiting for the fix to show up in the alpha manuals before closing...
          Hide
          Kim Haase added a comment -

          Closing, since fixes have appeared in latest alpha manuals.

          Show
          Kim Haase added a comment - Closing, since fixes have appeared in latest alpha manuals.

            People

            • Assignee:
              Kim Haase
              Reporter:
              Kim Haase
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development