Derby
  1. Derby
  2. DERBY-4475

[patch] roleName isn't trimmed as expected

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 10.5.3.0
    • Fix Version/s: 10.5.3.2, 10.6.1.0
    • Component/s: JDBC
    • Labels:
      None

      Description

      (from patch)

      public static String parseRoleId(String roleName) throws StandardException
      {

      • roleName.trim();
        + roleName = roleName.trim();
        // NONE is a special case and is not allowed with its special
        // meaning in SET ROLE <value specification>. Even if there is
        // a role with case normal form "NONE", we require it to be
      1. derby-4475.diff
        2 kB
        Dag H. Wanvik
      2. derby-4475.stat
        0.1 kB
        Dag H. Wanvik
      3. trim.diff
        0.6 kB
        Dave Brosius

        Issue Links

          Activity

          Dave Brosius created issue -
          Dave Brosius made changes -
          Field Original Value New Value
          Attachment trim.diff [ 12427878 ]
          Dave Brosius made changes -
          Summary [patch] role [patch] roleName isn't trimmed as expected
          Affects Version/s 10.5.3.0 [ 12314117 ]
          Issue & fix info [Patch Available]
          Priority Major [ 3 ] Trivial [ 5 ]
          Description (from patch)

            public static String parseRoleId(String roleName) throws StandardException
            {
          - roleName.trim();
          + roleName = roleName.trim();
            // NONE is a special case and is not allowed with its special
            // meaning in SET ROLE <value specification>. Even if there is
            // a role with case normal form "NONE", we require it to be
          Component/s JDBC [ 11407 ]
          Kristian Waagan made changes -
          Link This issue is duplicated by DERBY-4474 [ DERBY-4474 ]
          Hide
          Dag H. Wanvik added a comment -

          Thanks, Dave. Uploading a patch derby-4475 which includes your patch + new test cases.
          Will commit this shortly as soon as I have run all regression tests.

          Show
          Dag H. Wanvik added a comment - Thanks, Dave. Uploading a patch derby-4475 which includes your patch + new test cases. Will commit this shortly as soon as I have run all regression tests.
          Dag H. Wanvik made changes -
          Attachment derby-4475.diff [ 12428167 ]
          Attachment derby-4475.stat [ 12428168 ]
          Hide
          Dag H. Wanvik added a comment -

          Regressions passed, committed as svn 891350. Thanks Dave.
          If you have a developer id, you may want to assign yourself to this issue.
          I have marked it as resolved, pending your acceptance - if you agree that the issue has been solved, please close the issue (or I can do it).

          Show
          Dag H. Wanvik added a comment - Regressions passed, committed as svn 891350. Thanks Dave. If you have a developer id, you may want to assign yourself to this issue. I have marked it as resolved, pending your acceptance - if you agree that the issue has been solved, please close the issue (or I can do it).
          Dag H. Wanvik made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Issue & fix info [Patch Available]
          Resolution Not A Problem [ 8 ]
          Dag H. Wanvik made changes -
          Resolution Not A Problem [ 8 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Dag H. Wanvik made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Dag H. Wanvik made changes -
          Fix Version/s 10.6.0.0 [ 12313727 ]
          Dave Brosius made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Kathey Marsden made changes -
          Link This issue is required by DERBY-4994 [ DERBY-4994 ]
          Hide
          Kathey Marsden added a comment -

          Reopen for backport

          Show
          Kathey Marsden added a comment - Reopen for backport
          Kathey Marsden made changes -
          Resolution Fixed [ 1 ]
          Status Closed [ 6 ] Reopened [ 4 ]
          Kathey Marsden made changes -
          Assignee Kathey Marsden [ kmarsden ]
          Hide
          Kathey Marsden added a comment -

          Resolving after backport to 10.5. Assigning to Dave Brosius who submitted the patch. Thanks Dave!

          Show
          Kathey Marsden added a comment - Resolving after backport to 10.5. Assigning to Dave Brosius who submitted the patch. Thanks Dave!
          Kathey Marsden made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Assignee Kathey Marsden [ kmarsden ] Dave Brosius [ dbrosius ]
          Fix Version/s 10.5.3.2 [ 12315436 ]
          Resolution Fixed [ 1 ]
          Hide
          Knut Anders Hatlen added a comment -

          [bulk update] Close all resolved issues that haven't been updated for more than one year.

          Show
          Knut Anders Hatlen added a comment - [bulk update] Close all resolved issues that haven't been updated for more than one year.
          Knut Anders Hatlen made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Gavin made changes -
          Workflow jira [ 12484581 ] Default workflow, editable Closed status [ 12802874 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          2d 17h 58m 1 Dag H. Wanvik 16/Dec/09 18:00
          Resolved Resolved Reopened Reopened
          24s 1 Dag H. Wanvik 16/Dec/09 18:00
          Closed Closed Reopened Reopened
          413d 5h 33m 1 Kathey Marsden 02/Feb/11 23:47
          Reopened Reopened Resolved Resolved
          1d 23h 47m 2 Kathey Marsden 04/Feb/11 23:35
          Resolved Resolved Closed Closed
          863d 9h 58m 2 Knut Anders Hatlen 17/Jun/13 09:19

            People

            • Assignee:
              Dave Brosius
              Reporter:
              Dave Brosius
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development