Derby
  1. Derby
  2. DERBY-4472

[patch] non short circuit op, could cause eof problems

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 10.5.3.0
    • Fix Version/s: 10.5.3.2, 10.6.1.0
    • Component/s: JDBC
    • Labels:
      None

      Description

      (from patch)

      int offset = 0;

      • while( offset < dataDirectory.length() & Character.isSpaceChar( dataDirectory.charAt( offset)))
        + while( offset < dataDirectory.length() && Character.isSpaceChar( dataDirectory.charAt( offset)))
        offset ++;
        int leftParen = -1;
        int rightParen = -1;
      1. sc.diff
        1 kB
        Dave Brosius

        Issue Links

          Activity

          Dave Brosius created issue -
          Dave Brosius made changes -
          Field Original Value New Value
          Attachment sc.diff [ 12427876 ]
          Hide
          Kristian Waagan added a comment -

          Hi Dave,

          Thank you for contributing patches to Derby.
          I had look at the patch, and the change looks good.
          Shouldn't the other occurrence of this problem, in the same class, be fixed too?

          FYI: If you plan to contribute larger patches to Derby, you should consider filling in a CLA (contributer license agreement) and send it to the ASF. See http://www.apache.org/licenses/ or http://wiki.apache.org/db-derby/DerbyContributorChecklist.

          Show
          Kristian Waagan added a comment - Hi Dave, Thank you for contributing patches to Derby. I had look at the patch, and the change looks good. Shouldn't the other occurrence of this problem, in the same class, be fixed too? FYI: If you plan to contribute larger patches to Derby, you should consider filling in a CLA (contributer license agreement) and send it to the ASF. See http://www.apache.org/licenses/ or http://wiki.apache.org/db-derby/DerbyContributorChecklist .
          Hide
          Dave Brosius added a comment -

          Updated patch to cover both cases

          Show
          Dave Brosius added a comment - Updated patch to cover both cases
          Dave Brosius made changes -
          Attachment sc.diff [ 12427922 ]
          Dave Brosius made changes -
          Attachment sc.diff [ 12427876 ]
          Hide
          Kristian Waagan added a comment -

          Thanks for the update.

          Committed the patch to trunk with revision 890692.

          Show
          Kristian Waagan added a comment - Thanks for the update. Committed the patch to trunk with revision 890692.
          Kristian Waagan made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Issue & fix info [Patch Available]
          Fix Version/s 10.6.0.0 [ 12313727 ]
          Resolution Fixed [ 1 ]
          Kathey Marsden made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Kathey Marsden made changes -
          Link This issue is required by DERBY-4994 [ DERBY-4994 ]
          Hide
          Kathey Marsden added a comment -

          Reopen for backport

          Show
          Kathey Marsden added a comment - Reopen for backport
          Kathey Marsden made changes -
          Resolution Fixed [ 1 ]
          Status Closed [ 6 ] Reopened [ 4 ]
          Hide
          Kathey Marsden added a comment -

          Assigning to myself for backport to 10.5

          Show
          Kathey Marsden added a comment - Assigning to myself for backport to 10.5
          Kathey Marsden made changes -
          Assignee Kathey Marsden [ kmarsden ]
          Hide
          Kathey Marsden added a comment -

          Finshed backport. Reclosing issue

          Show
          Kathey Marsden added a comment - Finshed backport. Reclosing issue
          Kathey Marsden made changes -
          Status Reopened [ 4 ] Closed [ 6 ]
          Assignee Kathey Marsden [ kmarsden ] Dave Brosius [ dbrosius ]
          Fix Version/s 10.5.3.2 [ 12315436 ]
          Resolution Fixed [ 1 ]
          Gavin made changes -
          Workflow jira [ 12484578 ] Default workflow, editable Closed status [ 12800096 ]

            People

            • Assignee:
              Dave Brosius
              Reporter:
              Dave Brosius
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development