Derby
  1. Derby
  2. DERBY-4367

Replace Utils.min and Utils.max in the client driver with standard methods in java.lang.Math

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 10.6.1.0
    • Fix Version/s: 10.6.1.0
    • Component/s: Network Client
    • Labels:
      None

      Description

      The client has a utility class implementing functions for choosing the smallest and the largest int. These functions are already defined in java.lang.Math, and should be used instead because they are more familiar and because there is no need to duplicate the functionality.

      1. derby-4367-1a-remove_min_max.stat
        0.2 kB
        Kristian Waagan
      2. derby-4367-1a-remove_min_max.diff
        7 kB
        Kristian Waagan

        Activity

        Hide
        Kristian Waagan added a comment -

        Closing.

        Show
        Kristian Waagan added a comment - Closing.
        Hide
        Kristian Waagan added a comment -

        Committed patch 1a to trunk with revision 810024.

        Show
        Kristian Waagan added a comment - Committed patch 1a to trunk with revision 810024.
        Hide
        Kristian Waagan added a comment -

        Attaching patch 1a, which deletes the min and max methods in Utils, and replaces all uses of them with the corresponding methods in java.lang.Math.

        I plan to commit this shortly.

        Show
        Kristian Waagan added a comment - Attaching patch 1a, which deletes the min and max methods in Utils, and replaces all uses of them with the corresponding methods in java.lang.Math. I plan to commit this shortly.

          People

          • Assignee:
            Kristian Waagan
            Reporter:
            Kristian Waagan
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development