Uploaded image for project: 'Derby'
  1. Derby
  2. DERBY-4311

BaseJDBCTestCase.assertErrorCode() never fails

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 10.6.1.0
    • Fix Version/s: 10.6.1.0
    • Component/s: Test
    • Labels:
      None
    • Urgency:
      Low

      Description

      BaseJDBCTestCase.assertErrorCode() doesn't throw an exception if the error code does not match the expected code.

      public static void assertErrorCode(String message, int expected, SQLException exception) {
      while (exception != null)
      {
      try

      { assertEquals(message, expected,exception.getErrorCode()); }

      catch (AssertionFailedError e)

      { // check and see if our error code is in a chained exception exception = exception.getNextException(); }

      }
      }

      If the error code doesn't match, assertEquals() will raise an error, but the exception is caught and silently ignored.

      Since none of the tests uses assertErrorCode() I suggest we remove it. We can re-implement one that works later if the need arises.

        Attachments

        1. assertErrorCode.diff
          1 kB
          Knut Anders Hatlen

          Activity

            People

            • Assignee:
              knutanders Knut Anders Hatlen
              Reporter:
              knutanders Knut Anders Hatlen
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: