There are quite a few instances of public static fields which appear to be intended to be constant, but which are not final.
The code would be safer if all the constant fields were made final.
Patch to follow for some of the problem fields.
The following also ought to be fixed:
org.apache.derby.iapi.services.property.PropertyUtil.servicePropertyList (e.g. use an accessor to lookup the values)
|Issue Type||Bug [ 1 ]||Improvement [ 4 ]|
|Derby Categories||[Data corruption, Security]||[Security]|
|Component/s||Build tools [ 11405 ]|
|Component/s||Network Client [ 11690 ]|
|Component/s||SQL [ 11408 ]|
|Component/s||Store [ 11412 ]|
|Affects Version/s||10.6.0.0 [ 12313727 ]|
|Issue & fix info||[Patch Available]|
|Status||Open [ 1 ]||Resolved [ 5 ]|
|Assignee||Knut Anders Hatlen [ knutanders ]|
|Fix Version/s||10.6.0.0 [ 12313727 ]|
|Resolution||Fixed [ 1 ]|
|Status||Resolved [ 5 ]||Closed [ 6 ]|
|Workflow||jira [ 12467030 ]||Default workflow, editable Closed status [ 12799768 ]|