[DERBY-4260] Make derbynet/NetworkServerControlClientCommandTest run regardless of the locale

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 10.6.1.0
• Fix Version/s: 10.8.2.2, 10.9.1.0
• Component/s: Test
• Labels: gsoc gsoc2011
• Urgency: Low
• Issue & fix info: Patch Available
• Assignee: Houx Zhang
• Reporter: Tiago R. Espinha
• Created: 06/Jun/09 07:44
• Updated: 25/Oct/11 17:09
• Resolved: 15/Aug/11 17:52

Description

The NetworkServerControlClientCommandTest has in it a check that will only run the test if the locale is set to 'en'.

It is open to suggestion the how to achieve this and whether it should be done. Since the test is a pretty generic one, I think it should be ran regardless of the locale.

Knut suggested we'd force the locale to 'en' on the setUp() and back to its previous value on the tearDown(). On a first analysis this seems like the ideal method to go about it. Just removing the check for the locale altogether might not be wise because of the calls to assertFailedPing() that involve some hardcoded strings.

Issue Links

• is part of: DERBY-5155 Make testcases pass in non-English locale
• relates to: DERBY-5155 Make testcases pass in non-English locale