Derby
  1. Derby
  2. DERBY-4228

Remove unused pre-i18n constructors in BatchUpdateException

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 10.5.1.1
    • Fix Version/s: 10.6.1.0
    • Component/s: Network Client
    • Labels:
      None

      Description

      client.am.BatchUpdateException contains a number of unused constructors. There is a comment saying that they should be removed when i18n is complete. Since the i18n work on the client driver has been completed, and the constructors are no longer used, they should be removed.

      1. constructors.diff
        2 kB
        Knut Anders Hatlen

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        4s 1 Knut Anders Hatlen 13/May/09 12:46
        In Progress In Progress Closed Closed
        6h 39m 1 Knut Anders Hatlen 13/May/09 19:26
        Gavin made changes -
        Workflow jira [ 12463317 ] Default workflow, editable Closed status [ 12799469 ]
        Knut Anders Hatlen made changes -
        Status In Progress [ 3 ] Closed [ 6 ]
        Fix Version/s 10.6.0.0 [ 12313727 ]
        Resolution Fixed [ 1 ]
        Hide
        Knut Anders Hatlen added a comment -

        Thanks, Kristian, for looking at the patch. All the regression tests ran cleanly, so I committed the patch to trunk with revision 774471.

        Show
        Knut Anders Hatlen added a comment - Thanks, Kristian, for looking at the patch. All the regression tests ran cleanly, so I committed the patch to trunk with revision 774471.
        Hide
        Kristian Waagan added a comment -

        +1 from me.
        Briefly looked at the patch, applied it and built Derby without errors after doing 'ant clobber'.

        Show
        Kristian Waagan added a comment - +1 from me. Briefly looked at the patch, applied it and built Derby without errors after doing 'ant clobber'.
        Knut Anders Hatlen made changes -
        Attachment constructors.diff [ 12407986 ]
        Hide
        Knut Anders Hatlen added a comment -

        Here's a patch that removes the unused constructors.

        Show
        Knut Anders Hatlen added a comment - Here's a patch that removes the unused constructors.
        Knut Anders Hatlen made changes -
        Field Original Value New Value
        Status Open [ 1 ] In Progress [ 3 ]
        Knut Anders Hatlen created issue -

          People

          • Assignee:
            Knut Anders Hatlen
            Reporter:
            Knut Anders Hatlen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development