Derby
  1. Derby
  2. DERBY-4190

Incorrect example for SYSCS_DIAG.CONTAINED_ROLES in the reference manual

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 10.5.1.1
    • Fix Version/s: 10.6.1.0
    • Component/s: Documentation
    • Labels:
      None

      Description

      The example for SYSCS_DIAG.CONTAINED_ROLES in the reference manual does not work.
      http://db.apache.org/derby/docs/dev/ref/rrefsyscsdiagtables.html

      The example looks like this:
      SELECT * FROM TABLE (SYSCS_DIAG.CONTAINED_ROLES(reader))

      There are two problems:

      1) the table needs an alias (for instance, append AS T1), otherwise this error is raised:
      ERROR 42X01: Syntax error: Encountered "<EOF>" at line 1, column 56.
      Issue the 'help' command for general information on IJ command syntax.
      Any unrecognized commands are treated as potential SQL commands and executed directly.
      Consult your DBMS server reference documentation for details of the SQL syntax supported by your server.

      2) the name of the role should be a string (needs single quotes), not an identifier, otherwise this error is raised:
      ERROR 42X04: Column 'READER' is either not in any table in the FROM list or appears within a join specification and is outside the scope of the join specification or appears in a HAVING clause and is not in the GROUP BY list. If this is a CREATE or ALTER TABLE statement then 'READER' is not a column in the target table.

      1. rrefsyscsdiagtables.html
        18 kB
        Bryan Pendleton
      2. docs.diff
        1 kB
        Bryan Pendleton

        Activity

        Hide
        Knut Anders Hatlen added a comment -

        Verified fix in latest alpha manuals. Closing.

        Show
        Knut Anders Hatlen added a comment - Verified fix in latest alpha manuals. Closing.
        Hide
        Bryan Pendleton added a comment -

        Thanks Kim and Dag for the reviews.

        I changed 'reader' to 'READER' and <i>current_role</i> to CURRENT_ROLE
        and submitted the change to the docs trunk as revision 835665.

        Show
        Bryan Pendleton added a comment - Thanks Kim and Dag for the reviews. I changed 'reader' to 'READER' and <i>current_role</i> to CURRENT_ROLE and submitted the change to the docs trunk as revision 835665.
        Hide
        Kim Haase added a comment -

        Thanks, Bryan! One more item: we typically say CURRENT_ROLE with no special font. It's actually a function.

        Show
        Kim Haase added a comment - Thanks, Bryan! One more item: we typically say CURRENT_ROLE with no special font. It's actually a function.
        Hide
        Dag H. Wanvik added a comment -

        Thanks for fixing this one, Bryan. +1 after the case change.

        Show
        Dag H. Wanvik added a comment - Thanks for fixing this one, Bryan. +1 after the case change.
        Hide
        Dag H. Wanvik added a comment -

        When a role is created, the identifier is converted to upper case internally
        unless it is a delimited identifier (as for other identifiers in Derby), so 'READER' would be good in the example.

        Show
        Dag H. Wanvik added a comment - When a role is created, the identifier is converted to upper case internally unless it is a delimited identifier (as for other identifiers in Derby), so 'READER' would be good in the example.
        Hide
        Bryan Pendleton added a comment -

        Attached is a patch proposal, and the resulting HTML page.

        In addition to the changes suggested by Knut, I also added some text
        and an example for the CURRENT_ROLE case.

        I wasn't sure if the example should read 'reader' or 'READER'; are
        role names generally upper case?

        Please have a look at the revised doc and let me know any comments.

        Show
        Bryan Pendleton added a comment - Attached is a patch proposal, and the resulting HTML page. In addition to the changes suggested by Knut, I also added some text and an example for the CURRENT_ROLE case. I wasn't sure if the example should read 'reader' or 'READER'; are role names generally upper case? Please have a look at the revised doc and let me know any comments.

          People

          • Assignee:
            Bryan Pendleton
            Reporter:
            Knut Anders Hatlen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development