Derby
  1. Derby
  2. DERBY-4067

ClientConnectionPoolDataSource.getPooledConnection and ClientXADataSource.getXAConnection ignore connection attributes

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 10.3.3.0, 10.4.2.0, 10.5.1.1
    • Fix Version/s: 10.5.3.2, 10.6.2.4, 10.7.1.1
    • Component/s: Network Client
    • Labels:
      None
    • Urgency:
      Normal

      Description

      The methods CCPDS.getPooledConnection and CXADS.getXAConnection fail to pick up attributes set with setConnectionAttributes(String).

      The current regression tests fail to detect this, because they obtain a connection using getConnection(). I'm not sure if this method should be present in a XADataSource at all, but this problem should be addressed by a separate issue.

        Issue Links

          Activity

          Kristian Waagan created issue -
          Hide
          Kristian Waagan added a comment -

          My initial fix causes a few tests to fail in J2EEDataSourceTest.
          Derby seems to throw two different kinds of exceptions when there is a bad attribute in the attribute string:
          o XJ212: Invalid attribute syntax: bad
          o XJ028: The URL 'jdbc:derby://localhost:1527/wombat;bad' is not properly formed.

          Show
          Kristian Waagan added a comment - My initial fix causes a few tests to fail in J2EEDataSourceTest. Derby seems to throw two different kinds of exceptions when there is a bad attribute in the attribute string: o XJ212: Invalid attribute syntax: bad o XJ028: The URL 'jdbc:derby://localhost:1527/wombat;bad' is not properly formed.
          Myrna van Lunteren made changes -
          Field Original Value New Value
          Affects Version/s 10.5.1.1 [ 12313771 ]
          Affects Version/s 10.5.0.0 [ 12313010 ]
          Hide
          Knut Anders Hatlen added a comment -

          Triaged for 10.5.2.

          Show
          Knut Anders Hatlen added a comment - Triaged for 10.5.2.
          Knut Anders Hatlen made changes -
          Urgency Normal
          Kristian Waagan made changes -
          Link This issue incorporates DERBY-2468 [ DERBY-2468 ]
          Kristian Waagan made changes -
          Link This issue relates to DERBY-4719 [ DERBY-4719 ]
          Hide
          Kristian Waagan added a comment -

          Patch 1a makes the data sources update their state from the contents of the connection attribute string before creating the connection.
          Note that I moved the update of the state before obtaining a log writer, as the log writer construction is dependent on attributes that can be set in the connection attribute string.
          I do plan to backport this fix if possible.

          This patch is a partial fix only, there are several unresolved issues remaining. I expect that these will be addressed as part of DERBY-4719.

          Regression tests passed (12830 tests).
          Patch ready for review.

          Show
          Kristian Waagan added a comment - Patch 1a makes the data sources update their state from the contents of the connection attribute string before creating the connection. Note that I moved the update of the state before obtaining a log writer, as the log writer construction is dependent on attributes that can be set in the connection attribute string. I do plan to backport this fix if possible. This patch is a partial fix only, there are several unresolved issues remaining. I expect that these will be addressed as part of DERBY-4719 . Regression tests passed (12830 tests). Patch ready for review.
          Kristian Waagan made changes -
          Attachment derby-4067-1a-update_attrs.diff [ 12449334 ]
          Kristian Waagan made changes -
          Issue & fix info [Patch Available]
          Hide
          Kristian Waagan added a comment -

          Committed to trunk with revision 965793.
          Will wait a bit before I backport and close.

          Show
          Kristian Waagan added a comment - Committed to trunk with revision 965793. Will wait a bit before I backport and close.
          Kristian Waagan made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Issue & fix info [Patch Available]
          Fix Version/s 10.7.0.0 [ 12314971 ]
          Resolution Fixed [ 1 ]
          Rick Hillegas made changes -
          Fix Version/s 10.7.1.1 [ 12315564 ]
          Fix Version/s 10.7.1.0 [ 12314971 ]
          Kathey Marsden made changes -
          Link This issue is required by DERBY-4994 [ DERBY-4994 ]
          Hide
          Kathey Marsden added a comment -

          Reopen for backport

          Show
          Kathey Marsden added a comment - Reopen for backport
          Kathey Marsden made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Hide
          Mike Matrigali added a comment -

          temp assigning to myself while backporting to 10.6 and 10.5

          Show
          Mike Matrigali added a comment - temp assigning to myself while backporting to 10.6 and 10.5
          Mike Matrigali made changes -
          Assignee Kristian Waagan [ kristwaa ] Mike Matrigali [ mikem ]
          Hide
          Mike Matrigali added a comment -

          backported to 10.6 and 10.5. resolving and resetting to original owner.

          Show
          Mike Matrigali added a comment - backported to 10.6 and 10.5. resolving and resetting to original owner.
          Mike Matrigali made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Assignee Mike Matrigali [ mikem ] Kristian Waagan [ kristwaa ]
          Fix Version/s 10.5.3.2 [ 12315436 ]
          Fix Version/s 10.6.2.3 [ 12315434 ]
          Resolution Fixed [ 1 ]
          Hide
          Kristian Waagan added a comment -

          Closing, assuming all work has been done for this issue now.

          Show
          Kristian Waagan added a comment - Closing, assuming all work has been done for this issue now.
          Kristian Waagan made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Gavin made changes -
          Workflow jira [ 12453187 ] Default workflow, editable Closed status [ 12797961 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          511d 21h 26m 1 Kristian Waagan 20/Jul/10 10:53
          Resolved Resolved Reopened Reopened
          197d 12h 37m 1 Kathey Marsden 02/Feb/11 23:30
          Reopened Reopened Resolved Resolved
          15d 17h 25m 1 Mike Matrigali 18/Feb/11 16:56
          Resolved Resolved Closed Closed
          41m 6s 1 Kristian Waagan 18/Feb/11 17:37

            People

            • Assignee:
              Kristian Waagan
              Reporter:
              Kristian Waagan
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development