Derby
  1. Derby
  2. DERBY-4052

SQLChar.copyState() doesn't copy localeFinder

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 10.5.1.1
    • Fix Version/s: 10.5.3.2, 10.6.2.2, 10.7.1.1
    • Component/s: SQL
    • Labels:
      None
    • Urgency:
      Low
    • Issue & fix info:
      Known fix, Newcomer

      Description

      The last line of SQLChar.copyState() looks incorrect.

      this.localeFinder = localeFinder;

      This line doesn't do anything, since the left side and the right side of the assignment are identical.

      It might be intentional, but in that case there should be a comment explaining why. Looking at the rest of the method, it looks like the intention is that the right side of the assignment should be other.localeFinder.

      1. derby-4052.stat
        0.1 kB
        Yun Lee
      2. derby-4052.patch
        0.5 kB
        Yun Lee

        Issue Links

          Activity

          Knut Anders Hatlen created issue -
          Hide
          Kristian Waagan added a comment -
          Show
          Kristian Waagan added a comment - FWIW, we commented on this already, quite a while ago: http://www.nabble.com/Bug%2C-or-can-the-code-be-deleted-commented--%28SQLChar%29-td14686112.html#a14686112
          Myrna van Lunteren made changes -
          Field Original Value New Value
          Affects Version/s 10.5.1.1 [ 12313771 ]
          Affects Version/s 10.5.0.0 [ 12313010 ]
          Hide
          Knut Anders Hatlen added a comment - - edited

          Triaged for 10.5.2. Looks like the fix is known: use other.localeFinder on the right side.

          Show
          Knut Anders Hatlen added a comment - - edited Triaged for 10.5.2. Looks like the fix is known: use other.localeFinder on the right side.
          Knut Anders Hatlen made changes -
          Urgency Low
          Issue & fix info [Known fix, Newcomer]
          Yun Lee made changes -
          Assignee Yun Lee [ yunlee ]
          Yun Lee made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Hide
          Yun Lee added a comment -

          Hi, Knut. I agree with copying from the other.localeFinder and attach a patch. Please check it, thanks!

          Show
          Yun Lee added a comment - Hi, Knut. I agree with copying from the other.localeFinder and attach a patch. Please check it, thanks!
          Yun Lee made changes -
          Attachment derby-4052.patch [ 12448946 ]
          Attachment derby-4052.stat [ 12448947 ]
          Yun Lee made changes -
          Issue & fix info [Known fix, Newcomer] [Known fix, Newcomer, Patch Available]
          Hide
          Knut Anders Hatlen added a comment -

          Hi Yun. The patch looks fine to me. Did you run the regression tests to see if it caused any problems?

          Show
          Knut Anders Hatlen added a comment - Hi Yun. The patch looks fine to me. Did you run the regression tests to see if it caused any problems?
          Hide
          Knut Anders Hatlen added a comment -

          All the regression tests ran cleanly in my environment.
          Committed revision 961892.

          Show
          Knut Anders Hatlen added a comment - All the regression tests ran cleanly in my environment. Committed revision 961892.
          Knut Anders Hatlen made changes -
          Status In Progress [ 3 ] Resolved [ 5 ]
          Issue & fix info [Known fix, Newcomer, Patch Available] [Known fix, Newcomer]
          Fix Version/s 10.7.0.0 [ 12314971 ]
          Resolution Fixed [ 1 ]
          Hide
          Yun Lee added a comment -

          Thanks for your check, Knut.

          I have examined the use of the localFinder, but haven't run test strcitly, I will improve it later. Thanks for your remind!

          Show
          Yun Lee added a comment - Thanks for your check, Knut. I have examined the use of the localFinder, but haven't run test strcitly, I will improve it later. Thanks for your remind!
          Yun Lee made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Myrna van Lunteren made changes -
          Link This issue is part of DERBY-4609 [ DERBY-4609 ]
          Rick Hillegas made changes -
          Fix Version/s 10.7.1.1 [ 12315564 ]
          Fix Version/s 10.7.1.0 [ 12314971 ]
          Kathey Marsden made changes -
          Link This issue is required by DERBY-4994 [ DERBY-4994 ]
          Hide
          Kathey Marsden added a comment -

          Reopen for backport.

          Show
          Kathey Marsden added a comment - Reopen for backport.
          Kathey Marsden made changes -
          Resolution Fixed [ 1 ]
          Status Closed [ 6 ] Reopened [ 4 ]
          Hide
          Mike Matrigali added a comment -

          backporting to 10.6 and 10.5, temp assigning to myself while backporting.

          Show
          Mike Matrigali added a comment - backporting to 10.6 and 10.5, temp assigning to myself while backporting.
          Mike Matrigali made changes -
          Assignee Yun Lee [ yunlee ] Mike Matrigali [ mikem ]
          Hide
          Mike Matrigali added a comment -

          backported to 10.5 and 10.6. resoloving and setting owner back to original.

          Show
          Mike Matrigali added a comment - backported to 10.5 and 10.6. resoloving and setting owner back to original.
          Mike Matrigali made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Assignee Mike Matrigali [ mikem ] Yun Lee [ yunlee ]
          Fix Version/s 10.5.3.2 [ 12315436 ]
          Fix Version/s 10.6.2.2 [ 12315370 ]
          Resolution Fixed [ 1 ]
          Knut Anders Hatlen made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Gavin made changes -
          Workflow jira [ 12452194 ] Default workflow, editable Closed status [ 12801138 ]

            People

            • Assignee:
              Yun Lee
              Reporter:
              Knut Anders Hatlen
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development