[DERBY-3911] BTreeController.reclaim_deleted_rows() may hide exceptions

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 10.5.1.1
• Fix Version/s: 10.5.1.1
• Component/s: Store
• Assignee: Knut Anders Hatlen
• Reporter: Knut Anders Hatlen
• Created: 14/Oct/08 16:01
• Updated: 04/May/09 18:23
• Resolved: 15/Oct/08 08:14

Description

BTreeController.reclaim_deleted_rows() contains this piece of code:

catch (java.lang.ClassCastException cce)

{ // because we give up the latch on the leaf before entering this // routine, the page might change from a leaf to branch. If that // happens this routine will get a ClassCastException, and we // just give up trying to reclaim space. }

finally

{ if (controlRow != null) controlRow.release(); return(purged_at_least_one_row); }

It intentionally hides ClassCastExceptions, but it also unintentionally hides all other exceptions because of the return statement in the finally clause.

Some related discussions can be found in DERBY-3216 and DERBY-3905.