[DERBY-3798] Remove unnecessary call to Hashtable.get() in TableScanResultSet.getNextRowCore()

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 10.5.1.1
• Fix Version/s: 10.5.1.1
• Component/s: SQL
• Issue & fix info: Newcomer
• Assignee: Junjie Peng
• Reporter: Knut Anders Hatlen
• Created: 25/Jul/08 09:46
• Updated: 30/Jun/09 16:06
• Resolved: 15/Aug/08 11:25

Description

I came across this piece of code in TableScanResultSet.getNextRowCore():

if (past2FutureTbl.get(rowLoc) != null)

{ past2FutureTbl.remove(rowLoc); continue; }

I believe the call to Hashtable.get() is unnecessary since Hashtable.remove() returns the object it removed or null if the key was not in the table. So I believe the code could be simplified like this without changing the behaviour:

if (past2FutureTbl.remove(rowLoc) != null)

{ continue; }