Uploaded image for project: 'Derby'
  1. Derby
  2. DERBY-3702

Remove xml-apis.jar because we no longer have to compile against jdk1.3

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 10.5.1.1
    • Build tools
    • None

    Description

      Knut Anders raised the issue of whether we still need this jar file: http://www.nabble.com/Is-xml-apis.jar-still-needed--td17584026.html#a17584026 I have built Derby without this jar file and run the regression tests under Java 5 and jdk1.4: they passed cleanly for me in both environments. I believe we can remove this jar file, which was added in revision 395643 in order to compile the xml support under jdk1.3--we no longer support that platform.

      Attachments

        1. derby-3702-02-aa-removeReferences.diff
          6 kB
          Richard N. Hillegas

        Activity

          Removed xml-apis.jar via subversion revision 662549.

          rhillegas Richard N. Hillegas added a comment - Removed xml-apis.jar via subversion revision 662549.

          Thanks Rick.
          In addition to removing it, we need to remove the references to it in these files:

          BUILDING.txt
          java/engine/org/apache/derby/iapi/types/build.xml
          java/engine/org/apache/derby/iapi/types/SqlXmlUtil.java
          java/testing/org/apache/derbyTesting/junit/build.xml
          java/testing/org/apache/derbyTesting/junit/XML.java
          tools/ant/properties/extrapath.properties
          tools/ide/netbeans/5.5/nbproject/project.xml
          tools/ide/netbeans/6.0/nbproject/project.xml

          knutanders Knut Anders Hatlen added a comment - Thanks Rick. In addition to removing it, we need to remove the references to it in these files: BUILDING.txt java/engine/org/apache/derby/iapi/types/build.xml java/engine/org/apache/derby/iapi/types/SqlXmlUtil.java java/testing/org/apache/derbyTesting/junit/build.xml java/testing/org/apache/derbyTesting/junit/XML.java tools/ant/properties/extrapath.properties tools/ide/netbeans/5.5/nbproject/project.xml tools/ide/netbeans/6.0/nbproject/project.xml

          For the record, I'm also able to build Derby without tools/java/xercesImpl.jar. I think that's a side-effect of Xerces being included as part of the Java runtime libraries in Sun's Java 1.4.2 and therefore part of my java14compile.classpath. I don't think we can rely on those classes being there in later JDKs (they were moved to another package in Java 1.5 in order to avoid conflicts with newer Xerces versions installed by the users) or in JDKs from other vendors, so I guess that jar file should be left in the repository for now.

          knutanders Knut Anders Hatlen added a comment - For the record, I'm also able to build Derby without tools/java/xercesImpl.jar. I think that's a side-effect of Xerces being included as part of the Java runtime libraries in Sun's Java 1.4.2 and therefore part of my java14compile.classpath. I don't think we can rely on those classes being there in later JDKs (they were moved to another package in Java 1.5 in order to avoid conflicts with newer Xerces versions installed by the users) or in JDKs from other vendors, so I guess that jar file should be left in the repository for now.

          Attaching derby-3702-02-aa-removeReferences.diff. This removes references to the xml-apis jarball across our scripts and header comments. Touches the following files:

          M java/engine/org/apache/derby/iapi/types/build.xml
          M java/engine/org/apache/derby/iapi/types/SqlXmlUtil.java
          M java/testing/org/apache/derbyTesting/junit/XML.java
          M java/testing/org/apache/derbyTesting/junit/build.xml
          M tools/ide/netbeans/6.0/nbproject/project.xml
          M tools/ide/netbeans/5.5/nbproject/project.xml
          M tools/ant/properties/extrapath.properties
          M BUILDING.txt

          Committed at subversion revision 664061.

          rhillegas Richard N. Hillegas added a comment - Attaching derby-3702-02-aa-removeReferences.diff. This removes references to the xml-apis jarball across our scripts and header comments. Touches the following files: M java/engine/org/apache/derby/iapi/types/build.xml M java/engine/org/apache/derby/iapi/types/SqlXmlUtil.java M java/testing/org/apache/derbyTesting/junit/XML.java M java/testing/org/apache/derbyTesting/junit/build.xml M tools/ide/netbeans/6.0/nbproject/project.xml M tools/ide/netbeans/5.5/nbproject/project.xml M tools/ant/properties/extrapath.properties M BUILDING.txt Committed at subversion revision 664061.

          People

            Unassigned Unassigned
            rhillegas Richard N. Hillegas
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: