[DERBY-3573] Argument checking for ResultSet.setFetchSize(int) is incorrect

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 10.3.1.4, 10.3.2.1
• Fix Version/s: 10.11.1.1
• Component/s: JDBC, Network Client
• Labels: derby_backport_reject_10_10 derby_triage10_8
• Urgency: Low
• Issue & fix info: Newcomer
• Assignee: Nirmal Fernando
• Reporter: Dyre Tjeldvoll
• Created: 27/Mar/08 16:13
• Updated: 03/Mar/14 22:52
• Resolved: 14/Oct/13 11:14

Description

The requirement that the argument to ResultSet.setFetchSize(int) be less than Statement.getMaxRows() was dropped in Java 6/JDBC 4, (it is not present in the Java 6 javadoc, but can still be seen in the Java 5 javadoc).

The reason why the client driver doesn't throw an exception in this case is because am.ResultSet incorrectly checks against ResultSet.maxRows_ and NOT am.Statement.getMaxRows(). So when am.Statement.setMaxRows(int) is called after a result set has already been created, am.ResultSet.setFechSize(int) will check against a stale value.

The question is what to do about this. The client driver clearly has a bug, but should we fix it by duplicating the old behavior found in the embedded driver, or change both drivers to comply with latest spec which allows any non-negative value as argument to ResultSet.setFetchSize(int)?

Issue Links

• is related to: DERBY-3203 Convert jdbcapi/statementJdbc20.java to JUnit