Derby
  1. Derby
  2. DERBY-3371

Strange (and untested) code fragment in RAMTransaction.addColumnToConglomerate()

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 10.4.1.3
    • Fix Version/s: 10.10.1.1
    • Component/s: Store
    • Labels:
      None

      Description

      RAMTransaction.addColumnToConglomerate() contains this piece of code:

      // remove old entry in the Conglomerate directory, and add new one
      if (tempCongloms != null)
      tempCongloms.remove(new Long(conglomId));
      tempCongloms.put(new Long(conglomId), conglom);

      1. According to the code coverage report (http://people.apache.org/~fuzzylogic/codecoverage/529822/_files/3fc.html#5) these lines are not tested. If possible, a test that covers them should be added to the regression suite.

      2. The null check looks either unnecessary (seems to be the case after a brief inspection of the code), or incomplete since the last line will throw a NullPointerException regardless of the check if tempCongloms is null.

      3. The call to remove() before put() is redundant, since HashMap.put() will remove the old mapping implicitly.

      4. It seems to me that the object that is put into the HashMap always is the same as the one that is removed, so perhaps all these lines could be deleted.

      1. test.diff
        2 kB
        Knut Anders Hatlen
      2. remove.diff
        1.0 kB
        Knut Anders Hatlen

        Issue Links

          Activity

          Hide
          Knut Anders Hatlen added a comment -

          Committed revision 1342566.

          Show
          Knut Anders Hatlen added a comment - Committed revision 1342566.
          Hide
          Knut Anders Hatlen added a comment -

          Attaching a patch that removes the unneeded lines. Regression tests ran cleanly with the patch.

          Show
          Knut Anders Hatlen added a comment - Attaching a patch that removes the unneeded lines. Regression tests ran cleanly with the patch.
          Hide
          Knut Anders Hatlen added a comment -

          Committed the test patch with revision 618299.

          Show
          Knut Anders Hatlen added a comment - Committed the test patch with revision 618299.
          Hide
          Knut Anders Hatlen added a comment -

          The attached patch makes T_AccessFactory.alterTable() run tests on both temporary and non-temporary conglomerates. This change ensures that the above mentioned code fragment is executed in the tests.

          Show
          Knut Anders Hatlen added a comment - The attached patch makes T_AccessFactory.alterTable() run tests on both temporary and non-temporary conglomerates. This change ensures that the above mentioned code fragment is executed in the tests.

            People

            • Assignee:
              Knut Anders Hatlen
              Reporter:
              Knut Anders Hatlen
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development