[DERBY-3338] CancelQueryTask.forgetContext() could be simplified.

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 10.4.2.0, 10.5.1.1
• Component/s: Services, SQL
• Assignee: Mamta A. Satoor
• Reporter: Daniel John Debrunner
• Created: 21/Jan/08 22:56
• Updated: 21/Jan/11 17:51
• Resolved: 11/Jun/08 04:36

Description

Minor issue but CancelQueryTask.forgetContext() has this code (in GenericStatementContext.java)

public void forgetContext() {
boolean mayStillRun = !cancel();
if (mayStillRun) {
synchronized (this)

{ statementContext = null; }
}
}

The mayStillRun = !cancel() is somewhat confusing. I can't see from the javadoc of TimerTask.cancel() how its return value could indicate the task may still run.
Less confusing code could be:

public void forgetContext() {
synchronized (this) { statementContext = null; }

cancel();
}

Issue Links

• is related to: DERBY-1848 jdbcapi/SetQueryTimeoutTest.java fails on IBM wctme 5.7