Derby
  1. Derby
  2. DERBY-2895

convert lang/declareGlobalTempTableJavaJDBC30.java to JUnit

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 10.6.1.0
    • Component/s: Test
    • Labels:
      None
    1. DERBY-2895_v2.diff
      119 kB
      Myrna van Lunteren
    2. DERBY-2895_v2.stat
      0.7 kB
      Myrna van Lunteren
    3. DERBY-2895_v3.diff
      122 kB
      Myrna van Lunteren
    4. DERBY-2895.diff-v1
      110 kB
      Ravinder Reddy
    5. STATUS-v1
      0.6 kB
      Ravinder Reddy

      Activity

      Hide
      Ravinder Reddy added a comment -

      I think this patch is ready for commit.
      to best of my knowledge , I have covered all the tests that old test covers.
      your comments/suggections/critics are highly appreciated.

      Thank You

      Show
      Ravinder Reddy added a comment - I think this patch is ready for commit. to best of my knowledge , I have covered all the tests that old test covers. your comments/suggections/critics are highly appreciated. Thank You
      Hide
      Kathey Marsden added a comment -

      Ravinder indicates that there is a patch ready for commit for this issue, but the patch available checkbox wasn't marked. I don't know if it still applies, but is worth a look.

      Show
      Kathey Marsden added a comment - Ravinder indicates that there is a patch ready for commit for this issue, but the patch available checkbox wasn't marked. I don't know if it still applies, but is worth a look.
      Hide
      Myrna van Lunteren added a comment -

      Attaching a second version of this patch...

      The original patch was fine, mostly, I had only some minor modifications
      Then got wondering about the number of tests, and decided to get the missing tests (TEST3F-TEST3I) into DeclareGlobalTempTableJavaTest.
      Then I noticed these the JDBC30 and the other tests weren't run with NetworkServer, and decided to make them run so.

      Also noticed that the test had been put in the section in _Suite for all tests, although it's using 1 fixture with PooledConnections, so it should not run with JSR169.

      I'll run suites.All next - if that looks good I think it's ready for commit.

      Show
      Myrna van Lunteren added a comment - Attaching a second version of this patch... The original patch was fine, mostly, I had only some minor modifications Then got wondering about the number of tests, and decided to get the missing tests (TEST3F-TEST3I) into DeclareGlobalTempTableJavaTest. Then I noticed these the JDBC30 and the other tests weren't run with NetworkServer, and decided to make them run so. Also noticed that the test had been put in the section in _Suite for all tests, although it's using 1 fixture with PooledConnections, so it should not run with JSR169. I'll run suites.All next - if that looks good I think it's ready for commit.
      Hide
      Myrna van Lunteren added a comment -

      Attaching an updated version of the patch - I forgot to deal with comments (and code, for good measure) > 80 chars.

      Show
      Myrna van Lunteren added a comment - Attaching an updated version of the patch - I forgot to deal with comments (and code, for good measure) > 80 chars.
      Hide
      Myrna van Lunteren added a comment -

      Testing was ok - I only saw a failure in StressMultiTest similar to DERBY-3757 with ibm16. Also ran with weme 6.2 and only saw pre-existing trouble.

      I committed the (updated) patch with revision 813528 to trunk.

      Show
      Myrna van Lunteren added a comment - Testing was ok - I only saw a failure in StressMultiTest similar to DERBY-3757 with ibm16. Also ran with weme 6.2 and only saw pre-existing trouble. I committed the (updated) patch with revision 813528 to trunk.

        People

        • Assignee:
          Ravinder Reddy
          Reporter:
          Ravinder Reddy
        • Votes:
          0 Vote for this issue
          Watchers:
          1 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development