The patch looks good to me; the hint in the error messages will be
indeed helpful to understand what's going on if the user has
I notice that you had to remove localized versions of J131 "A PROTOCOL
Data Stream Syntax Error was detected. Reason: 0x
." since this is
now extended. For these locales this message will then fall back to
I did not run any tests to verify these changes.
- Modified lines > 80
- Spurious blank diffs (lines 2288-2290)
I see you have updated the user docs and releaseNote.html of
DERBY-2108 accordingly, good! Some small comments on the latter:
> Summary of Change - SSL/TLS implemented for client/server
I would make the title more descriptive:
"Summary of Change - Encryption of data traffic between client and
server is now supported via SSL/TLS."
or some such.
> Rationale for Change - The messages had to be extended due to more
> failure scenarios when connecting a client to a Derby server.
I think this is the rationale for the changed error messages, not for
the issue's feature change which is introduction of SSL support.
I think the rationale here would be something like:
"Encryption of data traffic between client and server is a desired
security feature for Derby."
Another change not mentioned is that localized versions of J131 will
now fall back to English. You may want to add that, perhaps.