Details

    • Sub-task
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 10.1.1.0
    • Documentation
    • None
    • all

    Description

      These new limits should be documented. The page I assume most likely needs changes is:
      http://incubator.apache.org/derby/docs/ref/rrefidlengthlimits.html

      So I am planning on changing all of those to 128. Is that correct?

      Also, I did a preliminary search and couldn't find many other instances where we explicitely say anything has a limit of either 30 or 18. The only items I found were that numeric floating point constants are limited to a length of 30 characters, and index names have an 18 character max length. Should either or both of those go to 128? Should either of those or both be placed in the Limitations table (see the link above) as well?

      This is an easy patch to create, I can do it really easily if someone can provide me with answers to the above questions.

      Thanks!

      Attachments

        1. derby274.zip
          6 kB
          Jeff Levitt

        Activity

          jlevitt Jeff Levitt added a comment -

          Here is a patch, along with generated html output for review. This patch should only be committed when the parent JIRA issue is committed.

          jlevitt Jeff Levitt added a comment - Here is a patch, along with generated html output for review. This patch should only be committed when the parent JIRA issue is committed.

          Committed Jeff's patch, revision 180159, that documents new identifier limits. Files modified:
          incubator/derby/docs/trunk/src/ref/rrefidlengthlimits.dita
          incubator/derby/docs/trunk/src/ref/rrefsqlj20937.dita
          incubator/derby/docs/trunk/src/ref/rrefsqlj31580.dita

          Closing as "Fixed" based on Satheesh Bandaram <satheesh@Sourcery.Org> comment posted to derby-dev: "I think this patch looks good, though I haven't searched for any other references to older limits on identifier lengths." See http://mail-archives.apache.org/mod_mbox/db-derby-dev/200506.mbox/%3c42A64F0E.6080702@Sourcery.Org%3e
          Note that the comment in the commit record at http://mail-archives.apache.org/mod_mbox/db-derby-commits/200506.mbox/%3c20050605223319.41650.qmail@minotaur.apache.org%3e
          incorrectly references DERBY-287 instead of DERBY-274. The log comments for the three files were corrected to reference DERBY 274.

          jta Jean T. Anderson added a comment - Committed Jeff's patch, revision 180159, that documents new identifier limits. Files modified: incubator/derby/docs/trunk/src/ref/rrefidlengthlimits.dita incubator/derby/docs/trunk/src/ref/rrefsqlj20937.dita incubator/derby/docs/trunk/src/ref/rrefsqlj31580.dita Closing as "Fixed" based on Satheesh Bandaram <satheesh@Sourcery.Org> comment posted to derby-dev: "I think this patch looks good, though I haven't searched for any other references to older limits on identifier lengths." See http://mail-archives.apache.org/mod_mbox/db-derby-dev/200506.mbox/%3c42A64F0E.6080702@Sourcery.Org%3e Note that the comment in the commit record at http://mail-archives.apache.org/mod_mbox/db-derby-commits/200506.mbox/%3c20050605223319.41650.qmail@minotaur.apache.org%3e incorrectly references DERBY-287 instead of DERBY-274 . The log comments for the three files were corrected to reference DERBY 274.

          People

            jlevitt Jeff Levitt
            jlevitt Jeff Levitt
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: