Uploaded image for project: 'Derby'
  1. Derby
  2. DERBY-2720

remove dead code associated with unsupported National Char implementation

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 10.3.3.1, 10.9.1.0
    • SQL
    • None

    Description

      Derby still has some untested, unused code relating to a non-standard implementation of a Nationa Char type. The current code can be removed.
      I believe the interesting functionality associated with this is now provided by DERBY-1478 (territory based collation) . If Derby ever implements a
      National Char type it should do so differently than the existing code, collation should not be tied to the National Char type.

      I believe a future National char type might have to maintain a separate type id for compatibility with jdbc interface, but actual implmentation should be
      the same code as the char types. Collating of the the national char type should be supported in exactly same way as regular char types.

      If anyone is really intested in the national char code, it's history will always be available in svn, and a consistent version is available by looking at 10.0, 10.1,
      and 10.2 codelines. I would propose any removal of code only take place in trunk and not be backported to a released codeline.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            mamtas Mamta A. Satoor
            mikem Mike Matrigali
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment