Uploaded image for project: 'Derby'
  1. Derby
  2. DERBY-2419

Tighten encapsulation of state in TestConfiguration

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 10.3.1.4
    • 10.7.1.1
    • Test
    • None

    Description

      Parts of the state of TestConfiguration has been made public, which they should not be; DEFAULT_PORT and DEFAULT_HOSTNAME.
      Using these directly from the outside can cause settings overridden by the user to be ignored by tests. Further, a test should not care if the host/port it uses is the Derby default or the values set by the user running the test.

      To obtain a hostname and a port number, use the methods getPort and getHostName in TestConfiguration.

      Attachments

        1. derby-2419-1a-alternative1.diff
          0.7 kB
          Kristian Waagan
        2. derby-2419-2a-alternative2.diff
          4 kB
          Kristian Waagan
        3. derby-2419-2a-alternative2.stat
          0.4 kB
          Kristian Waagan
        4. derby-2419-refactor-01.diff
          2 kB
          Richard N. Hillegas
        5. derby-2419-3a-further_encapsulation.diff
          16 kB
          Kristian Waagan

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            kristwaa Kristian Waagan
            kristwaa Kristian Waagan
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment