Derby
  1. Derby
  2. DERBY-2419

Tighten encapsulation of state in TestConfiguration

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 10.3.1.4
    • Fix Version/s: 10.7.1.1
    • Component/s: Test
    • Labels:
      None

      Description

      Parts of the state of TestConfiguration has been made public, which they should not be; DEFAULT_PORT and DEFAULT_HOSTNAME.
      Using these directly from the outside can cause settings overridden by the user to be ignored by tests. Further, a test should not care if the host/port it uses is the Derby default or the values set by the user running the test.

      To obtain a hostname and a port number, use the methods getPort and getHostName in TestConfiguration.

      1. derby-2419-3a-further_encapsulation.diff
        16 kB
        Kristian Waagan
      2. derby-2419-refactor-01.diff
        2 kB
        Rick Hillegas
      3. derby-2419-2a-alternative2.stat
        0.4 kB
        Kristian Waagan
      4. derby-2419-2a-alternative2.diff
        4 kB
        Kristian Waagan
      5. derby-2419-1a-alternative1.diff
        0.7 kB
        Kristian Waagan

        Issue Links

          Activity

          No work has yet been logged on this issue.

            People

            • Assignee:
              Kristian Waagan
              Reporter:
              Kristian Waagan
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development