I implemented the TODO for testUnimplementedSQLObjectAttributes fixture with revision 590476.
I made a first cut at implementing getBestRowIdentifier by taking the tests from bestrowidentifier.sql and metadata.java with revision 592240.
However, I now have a question on the basic set up for this test as explained in the javadoc.
The javadoc indicates that for methods that return a resultset, there are to be 2 versions; one fixture that modifies the database, and one that doesn't.
With, if I understand this correctly, the idea that the ones that don't modify the database are to be used for the upgrade tests.
However, I'm wondering if this idea was dropped?
The javadoc appears unfinished, there are only tests for getTables and getColumns that have a modify and non-modify version, and the upgrade tests appear to execute any test that start with 'test' except for 'testGetTablesModify'.
If I don't hear anything, I'm going to adjust the javadoc on the modify/non modify bit to only apply to getTables and getColumns tests.