Derby
  1. Derby
  2. DERBY-2226

Move column bitset computation to IndexToBaseRowNode

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 10.3.1.4
    • Component/s: SQL
    • Labels:
      None
    • Bug behavior facts:
      Performance

      Description

      The constructor for IndexRowToBaseRowResultSet
      takes a bitset describing the columns coming from the heap and a
      bitset describing the columns coming from the index. But in every
      IndexRowToBaseRowResultSet one also has to compute all referenced
      columns (union of heap and index bitsets), and frequently also those
      columns only coming from the heap (set difference between heap and
      index).

      But the value of these "set products" seem only to depend on objects
      that are fixed at compile time (in IndexToBaseRowNode), so it would be
      cleaner (and possibly more efficient) to compute these products there.

      1. derby-2226.v2.stat
        0.6 kB
        Dyre Tjeldvoll
      2. derby-2226.v2.diff
        10 kB
        Dyre Tjeldvoll
      3. derby-2226.v1.stat
        0.5 kB
        Dyre Tjeldvoll
      4. derby-2226.v1.diff
        9 kB
        Dyre Tjeldvoll

        Activity

        Dyre Tjeldvoll created issue -
        Dyre Tjeldvoll made changes -
        Field Original Value New Value
        Attachment derby-2226.v1.stat [ 12348641 ]
        Attachment derby-2226.v1.diff [ 12348640 ]
        Hide
        Dyre Tjeldvoll added a comment -

        I have attached a patch derby-2226.v1 for this issue.
        Derbyall and Junit tests pass.

        Please review.

        Show
        Dyre Tjeldvoll added a comment - I have attached a patch derby-2226.v1 for this issue. Derbyall and Junit tests pass. Please review.
        Dyre Tjeldvoll made changes -
        Attachment derby-2226.v2.stat [ 12348949 ]
        Attachment derby-2226.v2.diff [ 12348948 ]
        Hide
        Dyre Tjeldvoll added a comment -

        I have attached derby-2226.v2 which addresses the review comments.

        Show
        Dyre Tjeldvoll added a comment - I have attached derby-2226.v2 which addresses the review comments.
        Hide
        Knut Anders Hatlen added a comment -

        Thank you for addressing my comments, Dyre. Patch v2 looks good. Committed revision 496645.

        Show
        Knut Anders Hatlen added a comment - Thank you for addressing my comments, Dyre. Patch v2 looks good. Committed revision 496645.
        Knut Anders Hatlen made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Fix Version/s 10.3.0.0 [ 12310800 ]
        Dyre Tjeldvoll made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Knut Anders Hatlen made changes -
        Component/s SQL [ 11408 ]
        Component/s Performance [ 11709 ]
        Dag H. Wanvik made changes -
        Component/s Performance [ 11709 ]
        Dag H. Wanvik made changes -
        Derby Categories [Performance]
        Gavin made changes -
        Workflow jira [ 12393948 ] Default workflow, editable Closed status [ 12798331 ]

          People

          • Assignee:
            Dyre Tjeldvoll
            Reporter:
            Dyre Tjeldvoll
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development