[DERBY-2139] executing getXXX() for a column checks the column position is in range three times, reduce to one.

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Component/s: JDBC, SQL
• Labels: derby_triage10_11
• Urgency: Low
• Bug behavior facts: Performance
• Assignee: Unassigned
• Reporter: Daniel John Debrunner
• Created: 02/Dec/06 19:07
• Updated: 25/Jun/13 05:01

Description

On a getXXX() method the column position is checked in:

Once in EmbedResultSet.getColumn()

Twice in ValueRow.getColumn()

• once using explict code
• once implicitly when accessing the DataValueDescriptor array

Can reduce to once by solely relying on the array bounds checking. Then change the defined api to Row.getColumn to state that it throws IndexOutOfBoundsException for an invalid column. EmbedResultSet.getColumn() then can catch that exception and throw the required SQLException.

Probably need similar changes on the setXXX() methods and other getXXX methods and need to see how Row.getColumn() is used within the language layer.

Issue Links

• is related to: DERBY-1876 Investigate overhead of JDBC layer and compiled activation code for simple embedded read-only, forward ResultSets