Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 10.3.1.4
    • Component/s: Test
    • Labels:
      None
    1. derby-2025v3.diff
      2.09 MB
      Fernanda Pizzorno
    2. derby-2025v3.stat
      1 kB
      Fernanda Pizzorno
    3. derby-2025v2.diff
      2.09 MB
      Fernanda Pizzorno
    4. derby-2025v2.stat
      1 kB
      Fernanda Pizzorno
    5. derby-2025v1.diff
      2.09 MB
      Fernanda Pizzorno
    6. derby-2025v1.stat
      1 kB
      Fernanda Pizzorno

      Activity

      Hide
      Fernanda Pizzorno added a comment -

      Committed revision 481252.

      Show
      Fernanda Pizzorno added a comment - Committed revision 481252.
      Hide
      Knut Anders Hatlen added a comment -

      Thank you for addressing my comments, Fernanda. I think v3 looks good. +1 to commit.

      Show
      Knut Anders Hatlen added a comment - Thank you for addressing my comments, Fernanda. I think v3 looks good. +1 to commit.
      Hide
      Fernanda Pizzorno added a comment -

      I have changed verifyData() in the attached patch(derby-2025v3.diff) so that it uses the ResultSet.getBytes() method instead of ResultSet.getString() when verifying the use of the ResultSet.updateBytes method on columns of type CHAR, VARCHAR or LONG VARCHAR.

      I have successfully run lang/_Suite with this patch. Can someone please review it?

      Show
      Fernanda Pizzorno added a comment - I have changed verifyData() in the attached patch(derby-2025v3.diff) so that it uses the ResultSet.getBytes() method instead of ResultSet.getString() when verifying the use of the ResultSet.updateBytes method on columns of type CHAR, VARCHAR or LONG VARCHAR. I have successfully run lang/_Suite with this patch. Can someone please review it?
      Hide
      Fernanda Pizzorno added a comment -

      Thank you for looking at the patch Knut Anders. The attached patch (derby-2025v2.diff) addresses your comments.

      I have succesfully run lang/_Suite with this patch. Can someone please review it?

      Show
      Fernanda Pizzorno added a comment - Thank you for looking at the patch Knut Anders. The attached patch (derby-2025v2.diff) addresses your comments. I have succesfully run lang/_Suite with this patch. Can someone please review it?
      Hide
      Knut Anders Hatlen added a comment -

      The patch looks good. Some small comments:

      • I believe testResultSetPositionedBeforeNextAfterDeleteRow() is missing fail() after rs.getString(1)
      • testUpdateXXXNotForUpdateColumns() is missing fail() after rs.updateInt()
      • in testInsertRowReadOnlyRS(), rs.updateInt(2, 5000) is unreachable because fail() is called on the line before
      • testDeleteRowWithSetCursorName(), testUpdateRowWithSetCursorName(), runTestUpdateXXXWithAllDatatypes(), runTestUpdateObjectWithAllDatatypes() and verifyData() have asserts or calls to fail() which cause errors when an unexpected exception is called. Wouldn't it be better to re-throw the exceptions in order to preserve the stack traces?
      • testUpdateXXXWithAllDatatypes() and testUpdateObjectWithAllDatatypes() have finally clauses which clean up the database. If an error happens in the test case, an error in the finally clause might hide the actual error.
      • tearDown() could be removed since it doesn't do anything super.tearDown() wouldn't do
      • Would it be better if the suite were constructed from a baseSuite() method which returned all test cases with no decorator? suite() could return a test suite with baseSuite() + clientServerDecorator(baseSuite()). Then we wouldn't have to start/stop the network server more than once.
      • typo in class javadoc: resutlset
      • typo in comment in suite(): XtestInsertRowAftrerCommit
      Show
      Knut Anders Hatlen added a comment - The patch looks good. Some small comments: I believe testResultSetPositionedBeforeNextAfterDeleteRow() is missing fail() after rs.getString(1) testUpdateXXXNotForUpdateColumns() is missing fail() after rs.updateInt() in testInsertRowReadOnlyRS(), rs.updateInt(2, 5000) is unreachable because fail() is called on the line before testDeleteRowWithSetCursorName(), testUpdateRowWithSetCursorName(), runTestUpdateXXXWithAllDatatypes(), runTestUpdateObjectWithAllDatatypes() and verifyData() have asserts or calls to fail() which cause errors when an unexpected exception is called. Wouldn't it be better to re-throw the exceptions in order to preserve the stack traces? testUpdateXXXWithAllDatatypes() and testUpdateObjectWithAllDatatypes() have finally clauses which clean up the database. If an error happens in the test case, an error in the finally clause might hide the actual error. tearDown() could be removed since it doesn't do anything super.tearDown() wouldn't do Would it be better if the suite were constructed from a baseSuite() method which returned all test cases with no decorator? suite() could return a test suite with baseSuite() + clientServerDecorator(baseSuite()). Then we wouldn't have to start/stop the network server more than once. typo in class javadoc: resutlset typo in comment in suite(): XtestInsertRowAftrerCommit
      Hide
      Fernanda Pizzorno added a comment -

      The attached patch (derby-2025v1.diff) converts the test lang/updatableResultSet.java to Junit.

      A summary of what it tested by this test can be found at: http://wiki.apache.org/db-derby/UpdatableResultSetTestCoverage.

      I have successfully run lang._Suite with this patch. Can someone please review it?

      Show
      Fernanda Pizzorno added a comment - The attached patch (derby-2025v1.diff) converts the test lang/updatableResultSet.java to Junit. A summary of what it tested by this test can be found at: http://wiki.apache.org/db-derby/UpdatableResultSetTestCoverage . I have successfully run lang._Suite with this patch. Can someone please review it?

        People

        • Assignee:
          Fernanda Pizzorno
          Reporter:
          Fernanda Pizzorno
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development