Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 10.3.1.4
    • Component/s: Test
    • Labels:
      None
    1. derby-1962v2.stat
      1 kB
      Fernanda Pizzorno
    2. derby-1962v2.diff
      29 kB
      Fernanda Pizzorno
    3. derby-1962.stat
      1 kB
    4. derby-1962.diff
      28 kB

      Activity

      Hide
      Fernanda Pizzorno added a comment -

      The attached patch (derby-1962.diff) converts the test jdbcapi/resultsetJdbc30.java to Junit.

      A summary of what it tested by this test can be found at: http://wiki.apache.org/db-derby/ResultSetJDBC30TestCoverage.

      I have successfully run jdbcapi with this patch. Can someone please review it?

      Show
      Fernanda Pizzorno added a comment - The attached patch (derby-1962.diff) converts the test jdbcapi/resultsetJdbc30.java to Junit. A summary of what it tested by this test can be found at: http://wiki.apache.org/db-derby/ResultSetJDBC30TestCoverage . I have successfully run jdbcapi with this patch. Can someone please review it?
      Hide
      Knut Anders Hatlen added a comment -

      I think the patch looks good, but it seems the preferred way to make an embedded-only suite has changed to

      public static Test suite()

      { return TestConfiguration.embeddedSuite(ResultSetJDBC30Test.class); }

      Minor nits (not important to fix, only suggestions on how to reduce the amount of code in case you plan to convert more tests to JUnit):

      • I think fail(...) is clearer than assertTrue(..., false)
      • it is not necessary to retrieve the connection object so often since BaseJDBCTestCase has helper methods like createStatement(), prepareStatement() and commit().
      Show
      Knut Anders Hatlen added a comment - I think the patch looks good, but it seems the preferred way to make an embedded-only suite has changed to public static Test suite() { return TestConfiguration.embeddedSuite(ResultSetJDBC30Test.class); } Minor nits (not important to fix, only suggestions on how to reduce the amount of code in case you plan to convert more tests to JUnit): I think fail(...) is clearer than assertTrue(..., false) it is not necessary to retrieve the connection object so often since BaseJDBCTestCase has helper methods like createStatement(), prepareStatement() and commit().
      Hide
      Daniel John Debrunner added a comment -

      If the test is only to run under embedded it should contain comments indicating why that is the case.
      Makes it easier for folks looking at the code later to figure out why it's not being run with client/server.

      Show
      Daniel John Debrunner added a comment - If the test is only to run under embedded it should contain comments indicating why that is the case. Makes it easier for folks looking at the code later to figure out why it's not being run with client/server.
      Hide
      Fernanda Pizzorno added a comment -

      Knut Anders' comments are addressed in the attached patch (derby-1962v2.diff). I have succesfully run org.apache.derbyTesting.functionTests.tests.jdbcapi._Suite with this patch. Can someone please review it?

      I don't see a reason why this test should only run under Embedded so I have changed it so that it will also run under Derby Client.

      Show
      Fernanda Pizzorno added a comment - Knut Anders' comments are addressed in the attached patch (derby-1962v2.diff). I have succesfully run org.apache.derbyTesting.functionTests.tests.jdbcapi._Suite with this patch. Can someone please review it? I don't see a reason why this test should only run under Embedded so I have changed it so that it will also run under Derby Client.
      Hide
      Knut Anders Hatlen added a comment -

      Committed revision 465694.

      Show
      Knut Anders Hatlen added a comment - Committed revision 465694.

        People

        • Assignee:
          Fernanda Pizzorno
          Reporter:
          Fernanda Pizzorno
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development