Derby
  1. Derby
  2. DERBY-1952

Remove the running of JUnit tests from the old derby test harness to allow faster conversion to a pure-Junit world.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 10.3.1.4
    • Component/s: Test
    • Labels:
      None

      Description

      Assuming we had a top-level JUnit suite that ran all the Junit tests
      successfully (with the same configuration coverage as they are run today
      in derbyall) switch to a dual testing environment until
      all the tests were converted to JUnit. This would include removing all
      the JUnit tests from the old harness suite files.

      That is if one wanted to run all the tests one would have to run:

      derbyall with the old harness
      suites.All using JUnit test runners directly.

      Discussion thread is:

      http://mail-archives.apache.org/mod_mbox/db-derby-dev/200610.mbox/%3c452553E8.4070805@apache.org%3e

      Since no objections have been raised I will make progress on this.

        Issue Links

          Activity

          Hide
          Daniel John Debrunner added a comment -

          In order to run without the old harness jdbc4.VerifySignatures needs to be changed so that the classes are inspected to get the list of methods to check at test time and not suite time. Configurations are only changed when the test is run, not during suite setup. I will make this change which I think will be fairly simple, but it wil change the test from being many test cases to just one (or two) per configuration. Thus once the change is made the number of tests in suites.All wil drop significantely, while continuing to perform the same amount of testing.

          Show
          Daniel John Debrunner added a comment - In order to run without the old harness jdbc4.VerifySignatures needs to be changed so that the classes are inspected to get the list of methods to check at test time and not suite time. Configurations are only changed when the test is run, not during suite setup. I will make this change which I think will be fairly simple, but it wil change the test from being many test cases to just one (or two) per configuration. Thus once the change is made the number of tests in suites.All wil drop significantely, while continuing to perform the same amount of testing.
          Hide
          Daniel John Debrunner added a comment -

          Re-factored jdbc4.VerifySignatures to work as a pure-junit test and of course the changes do not significantely reduce the number of test cases in suites.All because previously it wasn't run there!

          Show
          Daniel John Debrunner added a comment - Re-factored jdbc4.VerifySignatures to work as a pure-junit test and of course the changes do not significantely reduce the number of test cases in suites.All because previously it wasn't run there!
          Hide
          Daniel John Debrunner added a comment -

          The last JUnit tests run by derbyall require a separate JVM as they test auto booting of Derby.
          This is achieved without the test harness by running them as ant junit tasks.
          To remove them from derbyall will require those ant targets can be run against a set of jars which is DERBY-2045, currently the ant targets can only be run from a codeline.

          Show
          Daniel John Debrunner added a comment - The last JUnit tests run by derbyall require a separate JVM as they test auto booting of Derby. This is achieved without the test harness by running them as ant junit tasks. To remove them from derbyall will require those ant targets can be run against a set of jars which is DERBY-2045 , currently the ant targets can only be run from a codeline.
          Hide
          Daniel John Debrunner added a comment -

          Instead of relying on running ant targets (DERBY-2045) I set up a wiki page that lists all the JUnit test classes that are needed to have full functional and unit test coverage.

          http://wiki.apache.org/db-derby/DerbyTopLevelJunitTests

          Show
          Daniel John Debrunner added a comment - Instead of relying on running ant targets ( DERBY-2045 ) I set up a wiki page that lists all the JUnit test classes that are needed to have full functional and unit test coverage. http://wiki.apache.org/db-derby/DerbyTopLevelJunitTests
          Hide
          Myrna van Lunteren added a comment -

          Looks fixed to me.

          Show
          Myrna van Lunteren added a comment - Looks fixed to me.

            People

            • Assignee:
              Daniel John Debrunner
              Reporter:
              Daniel John Debrunner
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development