Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 10.3.1.4
    • Component/s: Test
    • Labels:
      None
    1. derby1893_v2.diff
      13 kB
      Øystein Grøvlen
    2. derby1893_v2.stat
      0.7 kB
      Øystein Grøvlen
    3. derby1893.diff
      12 kB
      Øystein Grøvlen
    4. derby1893.stat
      0.6 kB
      Øystein Grøvlen

      Issue Links

        Activity

        Hide
        Øystein Grøvlen added a comment -

        Thanks to Bernt for committing the patch, and to Dan for improving it wrt to junit issues.

        Show
        Øystein Grøvlen added a comment - Thanks to Bernt for committing the patch, and to Dan for improving it wrt to junit issues.
        Hide
        Daniel John Debrunner added a comment -

        I was actually addressing the issues that Knut Anders raises in some cleanup related to DERBY-1952

        Show
        Daniel John Debrunner added a comment - I was actually addressing the issues that Knut Anders raises in some cleanup related to DERBY-1952
        Hide
        Knut Anders Hatlen added a comment -

        I have two comments to the patch (sorry I didn't notice before it was committed):

        • the suite method should have used suite.addTestSuite(LobLengthTest.class) instead of suite.addTest(new LobLengthTest("testXXX")). The way it is now, a new test case won't run automatically, and one might be led to belive that it succeeded when in fact it did not run.
        • the tearDown() method should set conn to null and call super.tearDown(). Tests not doing this have caused OutOfMemoryErrors before (DERBY-1845 and DERBY-1910). (It would be even better if the test class didn't have its own instance variable for the connection since the BaseJDBCTestClass already has many helper methods which remove the need for an explicit pointer to the connection.)
        Show
        Knut Anders Hatlen added a comment - I have two comments to the patch (sorry I didn't notice before it was committed): the suite method should have used suite.addTestSuite(LobLengthTest.class) instead of suite.addTest(new LobLengthTest("testXXX")). The way it is now, a new test case won't run automatically, and one might be led to belive that it succeeded when in fact it did not run. the tearDown() method should set conn to null and call super.tearDown(). Tests not doing this have caused OutOfMemoryErrors before ( DERBY-1845 and DERBY-1910 ). (It would be even better if the test class didn't have its own instance variable for the connection since the BaseJDBCTestClass already has many helper methods which remove the need for an explicit pointer to the connection.)
        Hide
        Bernt M. Johnsen added a comment -

        Committed revision 464504.

        Show
        Bernt M. Johnsen added a comment - Committed revision 464504.
        Hide
        Øystein Grøvlen added a comment -

        I have attached new versions of the patch and the stat output, derby1893_v2*.
        The patch is regenerated at the current head of trunk. In addition, I have
        removed the master file for the old test as pointed out by Fernanda.

        Show
        Øystein Grøvlen added a comment - I have attached new versions of the patch and the stat output, derby1893_v2*. The patch is regenerated at the current head of trunk. In addition, I have removed the master file for the old test as pointed out by Fernanda.
        Hide
        Fernanda Pizzorno added a comment -

        Shouldn't the master file (java/testing/org/apache/derbyTesting/functionTests/master/lobLengthTests.out) be deleted?

        Show
        Fernanda Pizzorno added a comment - Shouldn't the master file (java/testing/org/apache/derbyTesting/functionTests/master/lobLengthTests.out) be deleted?
        Hide
        Dyre Tjeldvoll added a comment -

        Patch looks good.
        +1 to commit

        Show
        Dyre Tjeldvoll added a comment - Patch looks good. +1 to commit
        Hide
        Øystein Grøvlen added a comment -

        derby1893.diff contains the changes to port the test
        largedata/lobLengthTests.java to junit. The test has been renamed to
        LobLengthTest to follow what seems to be the standard naming pattern
        for Derby Junit tests. I have also moved the test from largedata to jdbcapi
        and included it in the standard test suite since it seems that an
        extra large heap is no longer needed to run this test. The following
        files are affected by this patch:

        D java/testing/org/apache/derbyTesting/functionTests/tests/largedata/lobLengthTests.java
        Old test is removed

        D java/testing/org/apache/derbyTesting/functionTests/tests/largedata/lobLengthTests_app.properties
        No need for larger heap size anymore.

        M java/testing/org/apache/derbyTesting/functionTests/tests/largedata/copyfiles.ant
        No properties file to copy anymore.

        M java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/_Suite.java
        Adds the test to the jdbcapi junit test suite.

        A java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/LobLengthTest.java
        Converted test.

        M java/testing/org/apache/derbyTesting/functionTests/suites/largeDataTests.runall
        Removed test from largedata suite

        derbyall has been run with no failures.

        Show
        Øystein Grøvlen added a comment - derby1893.diff contains the changes to port the test largedata/lobLengthTests.java to junit. The test has been renamed to LobLengthTest to follow what seems to be the standard naming pattern for Derby Junit tests. I have also moved the test from largedata to jdbcapi and included it in the standard test suite since it seems that an extra large heap is no longer needed to run this test. The following files are affected by this patch: D java/testing/org/apache/derbyTesting/functionTests/tests/largedata/lobLengthTests.java Old test is removed D java/testing/org/apache/derbyTesting/functionTests/tests/largedata/lobLengthTests_app.properties No need for larger heap size anymore. M java/testing/org/apache/derbyTesting/functionTests/tests/largedata/copyfiles.ant No properties file to copy anymore. M java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/_Suite.java Adds the test to the jdbcapi junit test suite. A java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/LobLengthTest.java Converted test. M java/testing/org/apache/derbyTesting/functionTests/suites/largeDataTests.runall Removed test from largedata suite derbyall has been run with no failures.

          People

          • Assignee:
            Øystein Grøvlen
            Reporter:
            Øystein Grøvlen
          • Votes:
            1 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development