Derby
  1. Derby
  2. DERBY-1889

Convert jdbcapi/lobStreams.java to Junit

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 10.3.1.4
    • Component/s: Test
    • Labels:
      None
    1. derby-1889v1.diff
      51 kB
      Fernanda Pizzorno
    2. derby-1889v1.stat
      0.6 kB
      Fernanda Pizzorno
    3. DERBY-1889-TestCoverage.pdf
      52 kB
      Fernanda Pizzorno

      Issue Links

        Activity

        Hide
        Knut Anders Hatlen added a comment -

        Removed lobStreams.out and committed revision 452983.

        Show
        Knut Anders Hatlen added a comment - Removed lobStreams.out and committed revision 452983.
        Hide
        Knut Anders Hatlen added a comment -

        A patch is not needed just to delete a file. I'll do that manually. I noticed that java/testing/README.htm uses jdbcapi/lobStreams.java as an example. Perhaps the example should have been updated too?

        Show
        Knut Anders Hatlen added a comment - A patch is not needed just to delete a file. I'll do that manually. I noticed that java/testing/README.htm uses jdbcapi/lobStreams.java as an example. Perhaps the example should have been updated too?
        Hide
        Fernanda Pizzorno added a comment -

        The file java/testing/org/apache/derbyTesting/functionTests/master/lobStreams.out should have been removed when I removed the test. Should I submit another patch for that?

        Show
        Fernanda Pizzorno added a comment - The file java/testing/org/apache/derbyTesting/functionTests/master/lobStreams.out should have been removed when I removed the test. Should I submit another patch for that?
        Hide
        Knut Anders Hatlen added a comment -

        The name of the test was misspelt in encodingTests.runall. Fixed that and committed to trunk with revision 451255.

        Show
        Knut Anders Hatlen added a comment - The name of the test was misspelt in encodingTests.runall. Fixed that and committed to trunk with revision 451255.
        Hide
        Dyre Tjeldvoll added a comment -

        I have looked at the patch and it looks good. Bonus for consistent indentation in new and old files!
        +1 to commit.

        Show
        Dyre Tjeldvoll added a comment - I have looked at the patch and it looks good. Bonus for consistent indentation in new and old files! +1 to commit.
        Hide
        Fernanda Pizzorno added a comment -

        The attached patch (derby-1889v1.diff) converts the test jdbcapi/lobStreams.java to Junit. The test is dbcapi/LobStreamsTest.java.

        A summary of what it tested by this test can be found at: http://wiki.apache.org/db-derby/LobStreamsTestCoverage.

        I have successfully run derbynetmats, derbynetclientmats, encodingTests and jdbcapi with this patch. Can someone please review it?

        Show
        Fernanda Pizzorno added a comment - The attached patch (derby-1889v1.diff) converts the test jdbcapi/lobStreams.java to Junit. The test is dbcapi/LobStreamsTest.java. A summary of what it tested by this test can be found at: http://wiki.apache.org/db-derby/LobStreamsTestCoverage . I have successfully run derbynetmats, derbynetclientmats, encodingTests and jdbcapi with this patch. Can someone please review it?

          People

          • Assignee:
            Fernanda Pizzorno
            Reporter:
            Fernanda Pizzorno
          • Votes:
            1 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development